Formula-Student-Driverless-Simulator icon indicating copy to clipboard operation
Formula-Student-Driverless-Simulator copied to clipboard
verified publisher icon FS-Driverless

Workflow: Rework and build for ROS2 Humble and Jazzy

Open wouter-heerwegh opened this issue 1 year ago • 1 comments

This PR aims to introduce ROS2 building for Humble and Jazzy.

wouter-heerwegh avatar Oct 24 '24 12:10 wouter-heerwegh

Hi @pmo73,

I think this PR supersedes #359, without the changes of gcc, because AirSim is built with clang regardless. Do you think I need to port any other changes from your PR?

wouter-heerwegh avatar Oct 24 '24 13:10 wouter-heerwegh

Hello @wouter-heerwegh , sorry for the delayed reply. The changes look good to me so far and apart from the changes to gcc, I don't notice anything missing.

pmo73 avatar Oct 29 '24 16:10 pmo73

@pmo73 Do you think it's worth keeping the gcc parts from your initial PR?

wouter-heerwegh avatar Oct 29 '24 18:10 wouter-heerwegh

No I don't think so, There were a lot of changes, which would reduce the warnings, but as far as I could check the ros2 packages, they should be able to be compile with GCC also. I mean, if you want to be absolutely sure, you could add another matrix entry and compile the packages with both compilers.

pmo73 avatar Oct 30 '24 16:10 pmo73

Okay in that case I will just leave it as is, and I will close #359.

wouter-heerwegh avatar Oct 31 '24 08:10 wouter-heerwegh