Formula-Student-Driverless-Simulator icon indicating copy to clipboard operation
Formula-Student-Driverless-Simulator copied to clipboard

Fix absolute path problem in launch file

Open pmo73 opened this issue 2 years ago • 3 comments

This is a suggestion, how the problem with the absolute path can be fixed for ros2. With this solution it should be possible to run the simulator with ros2 in every directory

pmo73 avatar Jun 26 '23 15:06 pmo73

Hi @pmo73,

Sorry for the late reply

It seems like the PR is just trying to change the hardcoded path from the default ~/Formula-Student-Driverless-Simulator/settings.json directory to a different one. We changed the behaviour of how the settings file is loaded in #314 and #324, but we seemed to have forgotten that the camera's are loaded differently.

I think a better solution would be to use the python api to connect to the RPC server of the sim and call the getSettingsString function to get the actual settings from the sim. This way, there is no mismatch between the sim and a possible duplicate settings.json file.

Feel free to give some feedback.

wouter-heerwegh avatar Dec 24 '23 23:12 wouter-heerwegh

Hi @wouter-heerwegh , unfortunately I no longer have Unreal Engine installed to try this out. So I would close the PR. I was not aware that there is an RPC server that can be used to solve the problem.

pmo73 avatar Jan 13 '24 14:01 pmo73

Hi @pmo73,

I'll leave it open for now, and I'll try to look at it in the future.

wouter-heerwegh avatar Jan 13 '24 14:01 wouter-heerwegh