frr icon indicating copy to clipboard operation
frr copied to clipboard

nhrpd: Incomplete uniqueness bit handling

Open zmw12306 opened this issue 1 year ago • 5 comments

According to https://datatracker.ietf.org/doc/html/rfc2332.html#section-5.2.3 No storage/checking of uniqueness flag. No rejection of duplicate unique registrations

Another violation: "Any attempt to register a binding between the protocol address and an NBMA address when this bit is set MUST be rejected with a Code of '14 - Unique Internetworking Layer Address Already Registered' if the replying NHS already has a cache entry for the protocol address and the cache entry has the 'uniqueness' bit set."

I didn't resolve this because it may require large modifications, including struct nhrp_cache, nhrp_cache_update_binding, caller functions to nhrp_cache_update_binding and also nhrp_handle_registration_request...

zmw12306 avatar Apr 07 '25 21:04 zmw12306

Please PUT your design comments in the actual commit instead of the PR on the website. People look at the commits in the code not what is on the website in the future when they are trying to understand your code.

donaldsharp avatar Apr 08 '25 14:04 donaldsharp

still waiting for the comment to be addressed.

Jafaral avatar Apr 15 '25 02:04 Jafaral

still waiting for the comment to be addressed.

done

zmw12306 avatar May 20 '25 05:05 zmw12306

still waiting for the comment to be addressed.

Could you please take a look at the PR? Thanks!

zmw12306 avatar May 29 '25 07:05 zmw12306