frr icon indicating copy to clipboard operation
frr copied to clipboard

babeld: Add Flags checking in Hello TLV

Open zmw12306 opened this issue 1 year ago • 6 comments

According to RFC 8966: https://www.rfc-editor.org/rfc/rfc8966#name-hello

X: all other bits MUST be sent as 0 and silently ignored on reception

This means the Flags field could either be BABEL_UNICAST_HELLO 0x8000 or BABEL_MULTICAST_HELLO 0x0000, otherwise it is an invalid packet.

zmw12306 avatar Feb 20 '25 20:02 zmw12306

can you put your analysis about what is going on in the actual commit itself?

donaldsharp avatar Feb 20 '25 21:02 donaldsharp

can you put your analysis about what is going on in the actual commit itself?

This commit checks whether it is a valid MULTICAST hello, if not, the code logs a debug message and stops processing the packet. Do you want me to add this to the commit message?

zmw12306 avatar Feb 20 '25 21:02 zmw12306

can you put your analysis about what is going on in the actual commit itself?

This commit checks whether it is a valid MULTICAST hello, if not, the code logs a debug message and stops processing the packet. Do you want me to add this to the commit message?

Yes, that would be great.

riw777 avatar Feb 25 '25 15:02 riw777

waiting on commit message and clearing ci

riw777 avatar Mar 11 '25 13:03 riw777

failure looks related --

=========================== short test summary info ============================
FAILED babel_topo1/test_babel_topo1.py::test_zebra_ipv4_routingTable - Assert...
============= 1 failed, 1 passed, 1 skipped, 2 warnings in 45.37s ==============
Some rerun tests still failed.```

riw777 avatar Apr 01 '25 13:04 riw777

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 12 '25 22:06 github-actions[bot]