frr icon indicating copy to clipboard operation
frr copied to clipboard

lib: Introducing interface type to struct interface

Open raja-rajasekar opened this issue 2 years ago • 3 comments

Adding new field (interface type like Vlan,SVI,VRR etc..) in the struct interface to inform all zebra clients like ospf/bgp.

This can help protocols take appropriate action based on a specific interface type.

Ticket #3668878

Signed-off-by:.Chirag Shah.[email protected] Signed-off-by: Rajasekar Raja [email protected]

raja-rajasekar avatar Nov 14 '23 22:11 raja-rajasekar

Where is this interface type is gonna be used? For now, it's just an abandoned new struct member?

There is a bug/requirement to make the MACVLAN interface (vlan##-v0) ospf passive if configured via ospf network statement. A cleaner solution is to let the clients/protocols know the interface type to take action as needed.

raja-rajasekar avatar Nov 16 '23 18:11 raja-rajasekar

There is a bug/requirement to make the MACVLAN interface (vlan##-v0) ospf passive

This sounds like what is really needed is a better secondary indicator?

If a user has multiple MACVLAN devices and is not using the main device at all, they may well want to have OSPF enabled on some of the interfaces…

Also, what is preventing the user from either using interface based OSPF config, or putting ip ospf passive on the MACVLAN devices?

eqvinox avatar Nov 17 '23 15:11 eqvinox

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

github-actions[bot] avatar May 16 '24 01:05 github-actions[bot]