pimd: Dont not process invalid msdp peer address

[routingrocks]

The issue occurs when a new peer is created with an invalid peer address, which can cause the peer database to become corrupted. This can lead to various issues during shutdown, such as the example below:

(gdb) p/x *peer = {s_addr = 0x7fd5}

In other words, the peer hash key is based on the peer.s_addr value. When an invalid peer address is passed, it can break the entire peer cache logic like lookup, add, delete .

To fix this issue, return an error to Northbound validate and bail out if the source address is invalid.

Ticket:

Signed-off-by: Rajesh Varatharaj [email protected]

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13270/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13271/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-13271/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13271/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 7: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13271/artifact/TOPO7U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 1: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13271/artifact/TP1U1804AMD64/TopotestDetails/ Topotests Ubuntu 18.04 amd64 part 1: No useful log found

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-13271/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13271/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 i386 part 9: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13271/artifact/TOPO9U18I386/TopotestDetails/

Successful on other platforms/tests

• Addresssanitizer topotests part 9
• Topotests debian 10 amd64 part 0
• Topotests debian 10 amd64 part 5
• Topotests Ubuntu 18.04 arm8 part 7
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 arm8 part 8
• Topotests Ubuntu 18.04 i386 part 2
• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 amd64 part 5
• Topotests Ubuntu 18.04 arm8 part 6
• Addresssanitizer topotests part 3
• Topotests Ubuntu 18.04 i386 part 0
• Topotests Ubuntu 18.04 i386 part 5
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 amd64 part 2
• Topotests Ubuntu 18.04 i386 part 8
• Topotests debian 10 amd64 part 8
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 4
• Topotests Ubuntu 18.04 arm8 part 4
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 arm8 part 9
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests debian 10 amd64 part 9
• Topotests Ubuntu 18.04 i386 part 4
• Static analyzer (clang)
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 arm8 part 0
• Debian 9 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 9
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests debian 10 amd64 part 2
• Debian 10 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 5
• Topotests Ubuntu 18.04 amd64 part 6
• Addresssanitizer topotests part 6
• Ubuntu 18.04 deb pkg check
• Ubuntu 20.04 deb pkg check
• Topotests debian 10 amd64 part 1
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 1
• Addresssanitizer topotests part 5
• Addresssanitizer topotests part 4
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 4
• Topotests debian 10 amd64 part 3
• Topotests Ubuntu 18.04 arm8 part 3
• Addresssanitizer topotests part 1

[routingrocks]

ci:rerun

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13282/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 6: No useful log found

Successful on other platforms/tests

• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 arm8 part 8
• Addresssanitizer topotests part 7
• Topotests debian 10 amd64 part 9
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests Ubuntu 18.04 i386 part 7
• Addresssanitizer topotests part 5
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 amd64 part 2
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 amd64 part 4
• Topotests debian 10 amd64 part 8
• Ubuntu 20.04 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests Ubuntu 18.04 amd64 part 7
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 arm8 part 9
• Debian 10 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 5
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 2
• Addresssanitizer topotests part 3
• Topotests Ubuntu 18.04 arm8 part 7
• Topotests Ubuntu 18.04 i386 part 3
• Addresssanitizer topotests part 9
• CentOS 7 rpm pkg check
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 amd64 part 9
• Topotests Ubuntu 18.04 i386 part 9
• Static analyzer (clang)
• Topotests Ubuntu 18.04 i386 part 5
• Topotests Ubuntu 18.04 amd64 part 1
• Addresssanitizer topotests part 6
• Ubuntu 18.04 deb pkg check
• Topotests Ubuntu 18.04 i386 part 0
• Topotests debian 10 amd64 part 1
• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 arm8 part 5
• Topotests Ubuntu 18.04 amd64 part 6
• Addresssanitizer topotests part 0
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests debian 10 amd64 part 3
• Topotests debian 10 amd64 part 6
• Topotests debian 10 amd64 part 5
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests Ubuntu 18.04 arm8 part 3
• Topotests debian 10 amd64 part 4
• Addresssanitizer topotests part 4
• Debian 9 deb pkg check

[donaldsharp]

ci:rerun

[donaldsharp]

ci:rerun

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13298/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 i386 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO1U18I386-13298/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 1 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13298/artifact/TOPO1U18I386/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 i386 part 1: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13298/artifact/TOPO1U18I386/TopotestDetails/

Successful on other platforms/tests

• Addresssanitizer topotests part 5
• Topotests Ubuntu 18.04 arm8 part 3
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 amd64 part 2
• Addresssanitizer topotests part 4
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 8
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests debian 10 amd64 part 9
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests debian 10 amd64 part 3
• Static analyzer (clang)
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 arm8 part 7
• Addresssanitizer topotests part 9
• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 amd64 part 9
• Addresssanitizer topotests part 7
• Ubuntu 20.04 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 7
• Debian 10 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 5
• Topotests Ubuntu 18.04 i386 part 5
• Addresssanitizer topotests part 6
• Topotests Ubuntu 18.04 i386 part 0
• Topotests debian 10 amd64 part 1
• Addresssanitizer topotests part 3
• Topotests Ubuntu 18.04 arm8 part 5
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 4
• Topotests Ubuntu 18.04 i386 part 9
• Topotests Ubuntu 18.04 amd64 part 0
• Addresssanitizer topotests part 2
• Topotests debian 10 amd64 part 5
• Topotests Ubuntu 18.04 amd64 part 1
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Ubuntu 18.04 deb pkg check
• Topotests debian 10 amd64 part 7
• Debian 9 deb pkg check
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 amd64 part 6
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests Ubuntu 18.04 arm8 part 8
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 arm8 part 6
• Topotests debian 10 amd64 part 6

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13299/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13299/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Successful on other platforms/tests

• Topotests Ubuntu 18.04 arm8 part 3
• Addresssanitizer topotests part 5
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 amd64 part 2
• Topotests debian 10 amd64 part 3
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 8
• Topotests debian 10 amd64 part 9
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 arm8 part 9
• Topotests Ubuntu 18.04 amd64 part 3
• Static analyzer (clang)
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 i386 part 6
• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 8
• Addresssanitizer topotests part 9
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 arm8 part 5
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 amd64 part 9
• Addresssanitizer topotests part 7
• Ubuntu 20.04 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 5
• Debian 10 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 7
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 i386 part 0
• Topotests Ubuntu 18.04 i386 part 5
• Addresssanitizer topotests part 3
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 4
• Topotests Ubuntu 18.04 i386 part 9
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests debian 10 amd64 part 5
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests debian 10 amd64 part 7
• Debian 9 deb pkg check
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 8
• Ubuntu 18.04 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 6
• Addresssanitizer topotests part 6
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests Ubuntu 18.04 i386 part 7
• Topotests debian 10 amd64 part 6

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-13423/test

Topology Tests failed for Topotests debian 10 amd64 part 8 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO8DEB10AMD64/TopotestLogs/log_topotests.txt Topotests debian 10 amd64 part 8: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO8DEB10AMD64/TopotestDetails/

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-13423/test

Topology Tests failed for Topotests debian 10 amd64 part 0 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt Topotests debian 10 amd64 part 0: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 0: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-13423/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 0: No useful log found

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-13423/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPOU1804/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 0: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPOU1804/TopotestDetails/

Successful on other platforms/tests

• Topotests Ubuntu 18.04 arm8 part 3
• Addresssanitizer topotests part 4
• Topotests debian 10 amd64 part 9
• Addresssanitizer topotests part 5
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests Ubuntu 18.04 amd64 part 2
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 3
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 arm8 part 9
• Topotests Ubuntu 18.04 amd64 part 5
• Ubuntu 20.04 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 amd64 part 4
• Addresssanitizer topotests part 9
• Topotests Ubuntu 18.04 amd64 part 9
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 arm8 part 7
• Topotests Ubuntu 18.04 i386 part 8
• Addresssanitizer topotests part 3
• Debian 10 deb pkg check
• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 amd64 part 7
• Addresssanitizer topotests part 6
• Topotests Ubuntu 18.04 i386 part 5
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 arm8 part 5
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 i386 part 9
• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 8
• Static analyzer (clang)
• Addresssanitizer topotests part 2
• Debian 9 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 1
• Ubuntu 18.04 deb pkg check
• Topotests debian 10 amd64 part 5
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 arm8 part 6
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 8

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO8DEB10AMD64-13423/test

Topology Tests failed for Topotests debian 10 amd64 part 8 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO8DEB10AMD64/TopotestLogs/log_topotests.txt Topotests debian 10 amd64 part 8: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO8DEB10AMD64/TopotestDetails/

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-13423/test

Topology Tests failed for Topotests debian 10 amd64 part 0 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt Topotests debian 10 amd64 part 0: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 0: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-13423/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 0: No useful log found

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-13423/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPOU1804/TopotestLogs/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 0: Unknown Log <TopotestDetails> URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13423/artifact/TOPOU1804/TopotestDetails/

Report for pim_util.c | 2 issues
===============================================
< WARNING: else is not generally useful after a break or return
< #182: FILE: /tmp/f1-677421/pim_util.c:182:

[routingrocks]

fixing the warnings

[github-actions[bot]]

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

[routingrocks]

will revisit this PR in sometime