frr icon indicating copy to clipboard operation
frr copied to clipboard

babeld parsing issue

Open harryreps opened this issue 3 years ago • 2 comments

https://github.com/FRRouting/frr/blob/261e70c66a5d6f637fef33d59ab580a52f3e3203/babeld/message.c#L438-L475

I think the continue statements at Line 442, Line 454, and Line 472 should be goto done so that the following code can be executed.

https://github.com/FRRouting/frr/blob/261e70c66a5d6f637fef33d59ab580a52f3e3203/babeld/message.c#L689-L691

harryreps avatar Aug 16 '22 00:08 harryreps

This issue may lead to DoS attacks. Since the continue statements do not update the index i, the whole loop may not stop, i.e., an infinite loop.

harryreps avatar Aug 16 '22 01:08 harryreps

please open a PR

donaldsharp avatar Aug 16 '22 11:08 donaldsharp

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

github-actions[bot] avatar Feb 13 '23 02:02 github-actions[bot]

This issue will be automatically closed in the specified period unless there is further activity.

frrbot[bot] avatar Feb 13 '23 02:02 frrbot[bot]

reminder to avoid autoclose

harryreps avatar Feb 15 '23 20:02 harryreps

This issue will no longer be automatically closed.

frrbot[bot] avatar Feb 15 '23 20:02 frrbot[bot]