frr icon indicating copy to clipboard operation
frr copied to clipboard
verified publisher icon FRRouting

bgpd: SRV6 L3VPN + RouteReflector topology modifications

Open rvtch opened this issue 3 years ago • 13 comments

  1. Processing of prefixes (BGP_UPDATE) on RR node is set to the following algorithm (accordingly to RFC specs): A - AS local = AS of peer R - peer configured as RR Client L - prefix is locally originated S - send BGP update D - drop BGP update

A R L Action

- - -  S
- - +  S
- + -  S
- + +  S
+ - -  D
+ - +  S
+ + -  S
+ + +  S
  1. Minor changes accordingly to maintainers' proposals in #11348

PS topotests for processing SRV6 L3VPN case by RouteReflector will be added in next pull request.

rvtch avatar Jul 04 '22 14:07 rvtch

Outdated results 🛑

Basic BGPD CI results: FAILURE

_ _
Result FAILURE git merge/11522 bf486e63 Autoscript
Date 07/04/2022
Start 10:11:48
Finish 10:15:21
Run-Time 03:33
Total 65
Pass 62
Fail 3
Valgrind-Errors
Valgrind-Loss
Details vncregress-2022-07-04-10:11:48.txt
Log autoscript-2022-07-04-10:13:05.log.bz2
Memory

For details, please contact louberger

LabN-CI avatar Jul 04 '22 14:07 LabN-CI

Outdated results 🛑

Basic BGPD CI results: FAILURE

_ _
Result FAILURE git merge/11522 317a5832 Autoscript
Date 07/04/2022
Start 10:46:49
Finish 10:50:32
Run-Time 03:43
Total 65
Pass 62
Fail 3
Valgrind-Errors
Valgrind-Loss
Details vncregress-2022-07-04-10:46:49.txt
Log autoscript-2022-07-04-10:48:14.log.bz2
Memory

For details, please contact louberger

LabN-CI avatar Jul 04 '22 14:07 LabN-CI

Dup https://github.com/FRRouting/frr/pull/11348?

ton31337 avatar Jul 04 '22 14:07 ton31337

Not but include 11348.

rvtch avatar Jul 04 '22 14:07 rvtch

@ton31337 may be better way is to close this PR without merge and I'll merge changes into https://github.com/FRRouting/frr/pull/11348?

rvtch avatar Jul 05 '22 08:07 rvtch

this is changing rr updae route selection...

louberger avatar Jul 05 '22 14:07 louberger

@louberger Could you provide please with the details of error.

rvtch avatar Jul 06 '22 06:07 rvtch

Outdated results 🛑

Basic BGPD CI results: FAILURE

_ _
Result FAILURE git merge/11522 9b152376 Autoscript
Date 07/27/2022
Start 12:28:26
Finish 12:31:59
Run-Time 03:33
Total 65
Pass 62
Fail 3
Valgrind-Errors
Valgrind-Loss
Details vncregress-2022-07-27-12:28:26.txt
Log autoscript-2022-07-27-12:29:43.log.bz2
Memory

For details, please contact louberger

LabN-CI avatar Jul 27 '22 16:07 LabN-CI

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6709/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-6709/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6709/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-6709/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6709/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-6709/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6709/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 1
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 7
  • Topotests debian 10 amd64 part 5
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 5
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 9
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 2
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 0
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 9
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 7
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Debian 10 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-6709/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6709/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-6709/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6709/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-6709/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6709/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

<stdin>:1944: trailing whitespace.
    
<stdin>:923: new blank line at EOF.
+
<stdin>:1061: new blank line at EOF.
+
<stdin>:1709: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3686: FILE: /tmp/f1-12095/bgp_attr.c:3686:
< WARNING: line over 80 characters
< #3693: FILE: /tmp/f1-12095/bgp_attr.c:3693:
< WARNING: Too many leading tabs - consider code refactoring
< #3764: FILE: /tmp/f1-12095/bgp_attr.c:3764:
< WARNING: line over 80 characters
< #3767: FILE: /tmp/f1-12095/bgp_attr.c:3767:
< WARNING: line over 80 characters
< #3776: FILE: /tmp/f1-12095/bgp_attr.c:3776:
< WARNING: line over 80 characters
< #3777: FILE: /tmp/f1-12095/bgp_attr.c:3777:
< WARNING: Too many leading tabs - consider code refactoring
< #3778: FILE: /tmp/f1-12095/bgp_attr.c:3778:
< WARNING: line over 80 characters
< #3781: FILE: /tmp/f1-12095/bgp_attr.c:3781:
< WARNING: line over 80 characters
< #3783: FILE: /tmp/f1-12095/bgp_attr.c:3783:
< WARNING: line over 80 characters
< #3784: FILE: /tmp/f1-12095/bgp_attr.c:3784:
< WARNING: line over 80 characters
< #3789: FILE: /tmp/f1-12095/bgp_attr.c:3789:
Report for bgp_mplsvpn.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1263: FILE: /tmp/f1-12095/bgp_mplsvpn.c:1263:
< WARNING: line over 80 characters
< #1269: FILE: /tmp/f1-12095/bgp_mplsvpn.c:1269:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2829: FILE: /tmp/f1-12095/bgp_route.c:2829:

NetDEF-CI avatar Jul 28 '22 18:07 NetDEF-CI

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6732/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-6732/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6732/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-6732/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6732/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-6732/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6732/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 5
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 6
  • CentOS 7 rpm pkg check
  • Fedora 29 rpm pkg check
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 i386 part 5
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 9
  • Ubuntu 18.04 deb pkg check
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 5
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 0
  • Static analyzer (clang)

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-6732/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6732/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-6732/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6732/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-6732/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6732/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

<stdin>:1956: trailing whitespace.
    
<stdin>:935: new blank line at EOF.
+
<stdin>:1073: new blank line at EOF.
+
<stdin>:1721: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3686: FILE: /tmp/f1-28426/bgp_attr.c:3686:
< WARNING: line over 80 characters
< #3693: FILE: /tmp/f1-28426/bgp_attr.c:3693:
< WARNING: Too many leading tabs - consider code refactoring
< #3764: FILE: /tmp/f1-28426/bgp_attr.c:3764:
< WARNING: line over 80 characters
< #3767: FILE: /tmp/f1-28426/bgp_attr.c:3767:
< WARNING: line over 80 characters
< #3776: FILE: /tmp/f1-28426/bgp_attr.c:3776:
< WARNING: line over 80 characters
< #3777: FILE: /tmp/f1-28426/bgp_attr.c:3777:
< WARNING: Too many leading tabs - consider code refactoring
< #3778: FILE: /tmp/f1-28426/bgp_attr.c:3778:
< WARNING: line over 80 characters
< #3781: FILE: /tmp/f1-28426/bgp_attr.c:3781:
< WARNING: line over 80 characters
< #3783: FILE: /tmp/f1-28426/bgp_attr.c:3783:
< WARNING: line over 80 characters
< #3784: FILE: /tmp/f1-28426/bgp_attr.c:3784:
< WARNING: line over 80 characters
< #3789: FILE: /tmp/f1-28426/bgp_attr.c:3789:
Report for bgp_mplsvpn.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1263: FILE: /tmp/f1-28426/bgp_mplsvpn.c:1263:
< WARNING: line over 80 characters
< #1269: FILE: /tmp/f1-28426/bgp_mplsvpn.c:1269:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2829: FILE: /tmp/f1-28426/bgp_route.c:2829:

NetDEF-CI avatar Jul 30 '22 18:07 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6733/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:1956: trailing whitespace.
    
<stdin>:935: new blank line at EOF.
+
<stdin>:1073: new blank line at EOF.
+
<stdin>:1721: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3686: FILE: /tmp/f1-4875/bgp_attr.c:3686:
< WARNING: line over 80 characters
< #3693: FILE: /tmp/f1-4875/bgp_attr.c:3693:
< WARNING: Too many leading tabs - consider code refactoring
< #3764: FILE: /tmp/f1-4875/bgp_attr.c:3764:
< WARNING: line over 80 characters
< #3767: FILE: /tmp/f1-4875/bgp_attr.c:3767:
< WARNING: line over 80 characters
< #3776: FILE: /tmp/f1-4875/bgp_attr.c:3776:
< WARNING: line over 80 characters
< #3777: FILE: /tmp/f1-4875/bgp_attr.c:3777:
< WARNING: Too many leading tabs - consider code refactoring
< #3778: FILE: /tmp/f1-4875/bgp_attr.c:3778:
< WARNING: line over 80 characters
< #3781: FILE: /tmp/f1-4875/bgp_attr.c:3781:
< WARNING: line over 80 characters
< #3783: FILE: /tmp/f1-4875/bgp_attr.c:3783:
< WARNING: line over 80 characters
< #3784: FILE: /tmp/f1-4875/bgp_attr.c:3784:
< WARNING: line over 80 characters
< #3789: FILE: /tmp/f1-4875/bgp_attr.c:3789:
Report for bgp_mplsvpn.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1263: FILE: /tmp/f1-4875/bgp_mplsvpn.c:1263:
< WARNING: line over 80 characters
< #1269: FILE: /tmp/f1-4875/bgp_mplsvpn.c:1269:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2829: FILE: /tmp/f1-4875/bgp_route.c:2829:

NetDEF-CI avatar Jul 31 '22 16:07 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6905/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:1954: trailing whitespace.
    
<stdin>:933: new blank line at EOF.
+
<stdin>:1071: new blank line at EOF.
+
<stdin>:1719: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3686: FILE: /tmp/f1-4823/bgp_attr.c:3686:
< WARNING: line over 80 characters
< #3693: FILE: /tmp/f1-4823/bgp_attr.c:3693:
< WARNING: Too many leading tabs - consider code refactoring
< #3764: FILE: /tmp/f1-4823/bgp_attr.c:3764:
< WARNING: line over 80 characters
< #3767: FILE: /tmp/f1-4823/bgp_attr.c:3767:
< WARNING: line over 80 characters
< #3776: FILE: /tmp/f1-4823/bgp_attr.c:3776:
< WARNING: line over 80 characters
< #3777: FILE: /tmp/f1-4823/bgp_attr.c:3777:
< WARNING: Too many leading tabs - consider code refactoring
< #3778: FILE: /tmp/f1-4823/bgp_attr.c:3778:
< WARNING: line over 80 characters
< #3781: FILE: /tmp/f1-4823/bgp_attr.c:3781:
< WARNING: line over 80 characters
< #3783: FILE: /tmp/f1-4823/bgp_attr.c:3783:
< WARNING: line over 80 characters
< #3784: FILE: /tmp/f1-4823/bgp_attr.c:3784:
< WARNING: line over 80 characters
< #3789: FILE: /tmp/f1-4823/bgp_attr.c:3789:
Report for bgp_mplsvpn.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1263: FILE: /tmp/f1-4823/bgp_mplsvpn.c:1263:
< WARNING: line over 80 characters
< #1269: FILE: /tmp/f1-4823/bgp_mplsvpn.c:1269:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2853: FILE: /tmp/f1-4823/bgp_route.c:2853:

NetDEF-CI avatar Aug 13 '22 18:08 NetDEF-CI

@ton31337 @louberger could you kindly review this pr to unlock further srv6 implementation

rvtch avatar Aug 13 '22 20:08 rvtch

Could you kindly provide your feedback concerning this pull request? Unfortunately it hanged for a couple of months already. Please help to clarify what is wrong with it?

rvtch avatar Oct 06 '22 11:10 rvtch

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 13 '22 13:10 github-actions[bot]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7967/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details) Topotests debian 10 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7967/artifact/TOPO6DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details) Topotests Ubuntu 18.04 amd64 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7967/artifact/TOPO6U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 6: Failed (click for details) Topotests Ubuntu 18.04 i386 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7967/artifact/TOPO6U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 8: Incomplete (check logs for details)
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 9
  • Addresssanitizer topotests part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 8
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 6
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 7
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 3
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 5
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 5
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 8
  • Debian 10 deb pkg check
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 2
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 9

NetDEF-CI avatar Oct 19 '22 16:10 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7976/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:1968: trailing whitespace.
    
<stdin>:947: new blank line at EOF.
+
<stdin>:1085: new blank line at EOF.
+
<stdin>:1733: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3712: FILE: /tmp/f1-1741528/bgp_attr.c:3712:
< WARNING: line over 80 characters
< #3719: FILE: /tmp/f1-1741528/bgp_attr.c:3719:
< WARNING: Too many leading tabs - consider code refactoring
< #3790: FILE: /tmp/f1-1741528/bgp_attr.c:3790:
< WARNING: line over 80 characters
< #3793: FILE: /tmp/f1-1741528/bgp_attr.c:3793:
< WARNING: line over 80 characters
< #3802: FILE: /tmp/f1-1741528/bgp_attr.c:3802:
< WARNING: line over 80 characters
< #3803: FILE: /tmp/f1-1741528/bgp_attr.c:3803:
< WARNING: Too many leading tabs - consider code refactoring
< #3804: FILE: /tmp/f1-1741528/bgp_attr.c:3804:
< WARNING: line over 80 characters
< #3807: FILE: /tmp/f1-1741528/bgp_attr.c:3807:
< WARNING: line over 80 characters
< #3809: FILE: /tmp/f1-1741528/bgp_attr.c:3809:
< WARNING: line over 80 characters
< #3810: FILE: /tmp/f1-1741528/bgp_attr.c:3810:
< WARNING: line over 80 characters
< #3815: FILE: /tmp/f1-1741528/bgp_attr.c:3815:
Report for bgp_mplsvpn.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1311: FILE: /tmp/f1-1741528/bgp_mplsvpn.c:1311:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2990: FILE: /tmp/f1-1741528/bgp_route.c:2990:

NetDEF-CI avatar Oct 20 '22 11:10 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7983/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:1968: trailing whitespace.
    
<stdin>:947: new blank line at EOF.
+
<stdin>:1085: new blank line at EOF.
+
<stdin>:1733: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3712: FILE: /tmp/f1-2516515/bgp_attr.c:3712:
< WARNING: line over 80 characters
< #3719: FILE: /tmp/f1-2516515/bgp_attr.c:3719:
< WARNING: Too many leading tabs - consider code refactoring
< #3790: FILE: /tmp/f1-2516515/bgp_attr.c:3790:
< WARNING: line over 80 characters
< #3793: FILE: /tmp/f1-2516515/bgp_attr.c:3793:
< WARNING: line over 80 characters
< #3802: FILE: /tmp/f1-2516515/bgp_attr.c:3802:
< WARNING: line over 80 characters
< #3803: FILE: /tmp/f1-2516515/bgp_attr.c:3803:
< WARNING: Too many leading tabs - consider code refactoring
< #3804: FILE: /tmp/f1-2516515/bgp_attr.c:3804:
< WARNING: line over 80 characters
< #3807: FILE: /tmp/f1-2516515/bgp_attr.c:3807:
< WARNING: line over 80 characters
< #3809: FILE: /tmp/f1-2516515/bgp_attr.c:3809:
< WARNING: line over 80 characters
< #3810: FILE: /tmp/f1-2516515/bgp_attr.c:3810:
< WARNING: line over 80 characters
< #3815: FILE: /tmp/f1-2516515/bgp_attr.c:3815:
Report for bgp_mplsvpn.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1311: FILE: /tmp/f1-2516515/bgp_mplsvpn.c:1311:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2990: FILE: /tmp/f1-2516515/bgp_route.c:2990:

NetDEF-CI avatar Oct 20 '22 14:10 NetDEF-CI

Hi All, Dear @louberger and @pguibert6WIND ! Could you perform the review for this PR please? We have another set of SRv6 code to submit, but this hanged PR locks everything. Thank you very much in advance.

celotajs avatar Oct 22 '22 21:10 celotajs

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 24 '22 14:10 github-actions[bot]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8109/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:1968: trailing whitespace.
    
<stdin>:947: new blank line at EOF.
+
<stdin>:1085: new blank line at EOF.
+
<stdin>:1733: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3712: FILE: /tmp/f1-3740079/bgp_attr.c:3712:
< WARNING: line over 80 characters
< #3719: FILE: /tmp/f1-3740079/bgp_attr.c:3719:
< WARNING: Too many leading tabs - consider code refactoring
< #3790: FILE: /tmp/f1-3740079/bgp_attr.c:3790:
< WARNING: line over 80 characters
< #3793: FILE: /tmp/f1-3740079/bgp_attr.c:3793:
< WARNING: line over 80 characters
< #3802: FILE: /tmp/f1-3740079/bgp_attr.c:3802:
< WARNING: line over 80 characters
< #3803: FILE: /tmp/f1-3740079/bgp_attr.c:3803:
< WARNING: Too many leading tabs - consider code refactoring
< #3804: FILE: /tmp/f1-3740079/bgp_attr.c:3804:
< WARNING: line over 80 characters
< #3807: FILE: /tmp/f1-3740079/bgp_attr.c:3807:
< WARNING: line over 80 characters
< #3809: FILE: /tmp/f1-3740079/bgp_attr.c:3809:
< WARNING: line over 80 characters
< #3810: FILE: /tmp/f1-3740079/bgp_attr.c:3810:
< WARNING: line over 80 characters
< #3815: FILE: /tmp/f1-3740079/bgp_attr.c:3815:
Report for bgp_mplsvpn.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1568: FILE: /tmp/f1-3740079/bgp_mplsvpn.c:1568:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2992: FILE: /tmp/f1-3740079/bgp_route.c:2992:

NetDEF-CI avatar Oct 27 '22 14:10 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8266/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:1968: trailing whitespace.
    
<stdin>:947: new blank line at EOF.
+
<stdin>:1085: new blank line at EOF.
+
<stdin>:1733: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3712: FILE: /tmp/f1-849259/bgp_attr.c:3712:
< WARNING: line over 80 characters
< #3719: FILE: /tmp/f1-849259/bgp_attr.c:3719:
< WARNING: Too many leading tabs - consider code refactoring
< #3790: FILE: /tmp/f1-849259/bgp_attr.c:3790:
< WARNING: line over 80 characters
< #3793: FILE: /tmp/f1-849259/bgp_attr.c:3793:
< WARNING: line over 80 characters
< #3802: FILE: /tmp/f1-849259/bgp_attr.c:3802:
< WARNING: line over 80 characters
< #3803: FILE: /tmp/f1-849259/bgp_attr.c:3803:
< WARNING: Too many leading tabs - consider code refactoring
< #3804: FILE: /tmp/f1-849259/bgp_attr.c:3804:
< WARNING: line over 80 characters
< #3807: FILE: /tmp/f1-849259/bgp_attr.c:3807:
< WARNING: line over 80 characters
< #3809: FILE: /tmp/f1-849259/bgp_attr.c:3809:
< WARNING: line over 80 characters
< #3810: FILE: /tmp/f1-849259/bgp_attr.c:3810:
< WARNING: line over 80 characters
< #3815: FILE: /tmp/f1-849259/bgp_attr.c:3815:
Report for bgp_mplsvpn.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1568: FILE: /tmp/f1-849259/bgp_mplsvpn.c:1568:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2992: FILE: /tmp/f1-849259/bgp_route.c:2992:

NetDEF-CI avatar Nov 08 '22 14:11 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8267/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:1934: trailing whitespace.
    
<stdin>:913: new blank line at EOF.
+
<stdin>:1051: new blank line at EOF.
+
<stdin>:1699: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3712: FILE: /tmp/f1-876123/bgp_attr.c:3712:
< WARNING: line over 80 characters
< #3719: FILE: /tmp/f1-876123/bgp_attr.c:3719:
< WARNING: Too many leading tabs - consider code refactoring
< #3790: FILE: /tmp/f1-876123/bgp_attr.c:3790:
< WARNING: line over 80 characters
< #3793: FILE: /tmp/f1-876123/bgp_attr.c:3793:
< WARNING: line over 80 characters
< #3802: FILE: /tmp/f1-876123/bgp_attr.c:3802:
< WARNING: line over 80 characters
< #3803: FILE: /tmp/f1-876123/bgp_attr.c:3803:
< WARNING: Too many leading tabs - consider code refactoring
< #3804: FILE: /tmp/f1-876123/bgp_attr.c:3804:
< WARNING: line over 80 characters
< #3807: FILE: /tmp/f1-876123/bgp_attr.c:3807:
< WARNING: line over 80 characters
< #3809: FILE: /tmp/f1-876123/bgp_attr.c:3809:
< WARNING: line over 80 characters
< #3810: FILE: /tmp/f1-876123/bgp_attr.c:3810:
< WARNING: line over 80 characters
< #3815: FILE: /tmp/f1-876123/bgp_attr.c:3815:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2992: FILE: /tmp/f1-876123/bgp_route.c:2992:

NetDEF-CI avatar Nov 08 '22 14:11 NetDEF-CI

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 14 '22 14:11 github-actions[bot]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8373/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:1914: trailing whitespace.
    
<stdin>:893: new blank line at EOF.
+
<stdin>:1031: new blank line at EOF.
+
<stdin>:1679: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Report for bgp_attr.c | 22 issues
===============================================
< WARNING: line over 80 characters
< #3863: FILE: /tmp/f1-2823209/bgp_attr.c:3863:
< WARNING: line over 80 characters
< #3870: FILE: /tmp/f1-2823209/bgp_attr.c:3870:
< WARNING: Too many leading tabs - consider code refactoring
< #3941: FILE: /tmp/f1-2823209/bgp_attr.c:3941:
< WARNING: line over 80 characters
< #3944: FILE: /tmp/f1-2823209/bgp_attr.c:3944:
< WARNING: line over 80 characters
< #3953: FILE: /tmp/f1-2823209/bgp_attr.c:3953:
< WARNING: line over 80 characters
< #3954: FILE: /tmp/f1-2823209/bgp_attr.c:3954:
< WARNING: Too many leading tabs - consider code refactoring
< #3955: FILE: /tmp/f1-2823209/bgp_attr.c:3955:
< WARNING: line over 80 characters
< #3958: FILE: /tmp/f1-2823209/bgp_attr.c:3958:
< WARNING: line over 80 characters
< #3960: FILE: /tmp/f1-2823209/bgp_attr.c:3960:
< WARNING: line over 80 characters
< #3961: FILE: /tmp/f1-2823209/bgp_attr.c:3961:
< WARNING: line over 80 characters
< #3966: FILE: /tmp/f1-2823209/bgp_attr.c:3966:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #3020: FILE: /tmp/f1-2823209/bgp_route.c:3020:

NetDEF-CI avatar Nov 15 '22 11:11 NetDEF-CI

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 17 '22 15:11 github-actions[bot]

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

github-actions[bot] avatar Aug 08 '23 01:08 github-actions[bot]