frr icon indicating copy to clipboard operation
frr copied to clipboard
verified publisher icon FRRouting

bgpd: fixes a range BGP SRv6 L3 VPN bugs and drawbacks

Open rvtch opened this issue 3 years ago • 9 comments

  1. Hardcoded Locator Block Length, Locator Node Length, Transposition Length, Transposition Offset in SRv6 SID Sub-Sub-TLV. Now they are correctly calculated from the locator mask (/48 or/64) in the configuration for compatibility with Cisco IOS-XR.
  2. A length of SRv6 SID value length of SRv6 SID Sub-TLV is aligned to requirements of p.4 of draft-ietf-bess-srv6-services-15 for L3 VPN services.
  3. SRv6 Endpoint Behavior field of SRv6 SID Sub-TLV is set accordingly to IANA SRv6 Endpoint Behaviors asignments.
  4. MP_REACH_NLRI Next Hop is now IPv6 for both IPv4 and IPv6 prefixes.
  5. Improved L3 VPN scalability from 128 to 64K in label stack calculation.

rvtch avatar Jun 06 '22 12:06 rvtch

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5767/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-5767/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5767/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-5767/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5767/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-5767/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5767/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 8
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 1
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 5
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 arm8 part 1
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 0
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests debian 10 amd64 part 9
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 amd64 part 2

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-5767/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5767/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-5767/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5767/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-5767/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5767/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Report for bgp_attr.c | 12 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 40)
< #3640: FILE: /tmp/f1-10044/bgp_attr.c:3640:
< WARNING: line over 80 characters
< #3643: FILE: /tmp/f1-10044/bgp_attr.c:3643:
< WARNING: line over 80 characters
< #3647: FILE: /tmp/f1-10044/bgp_attr.c:3647:
< WARNING: line over 80 characters
< #3702: FILE: /tmp/f1-10044/bgp_attr.c:3702:
< WARNING: line over 80 characters
< #3703: FILE: /tmp/f1-10044/bgp_attr.c:3703:
< WARNING: line over 80 characters
< #4329: FILE: /tmp/f1-10044/bgp_attr.c:4329:
Report for bgpd.c | 2 issues
===============================================
< ERROR: open brace '{' following function declarations go on the next line
< #3878: FILE: /tmp/f1-10044/bgpd.c:3878:
Report for bgp_debug.c | 4 issues
===============================================
< WARNING: suspect code indent for conditional statements (8, 24)
< #470: FILE: /tmp/f1-10044/bgp_debug.c:470:
< WARNING: line over 80 characters
< #472: FILE: /tmp/f1-10044/bgp_debug.c:472:
Report for bgp_mplsvpn.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #1264: FILE: /tmp/f1-10044/bgp_mplsvpn.c:1264:
< WARNING: Missing a blank line after declarations
< #1264: FILE: /tmp/f1-10044/bgp_mplsvpn.c:1264:
< WARNING: line over 80 characters
< #1265: FILE: /tmp/f1-10044/bgp_mplsvpn.c:1265:
< WARNING: line over 80 characters
< #1275: FILE: /tmp/f1-10044/bgp_mplsvpn.c:1275:
< WARNING: line over 80 characters
< #1284: FILE: /tmp/f1-10044/bgp_mplsvpn.c:1284:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2981: FILE: /tmp/f1-10044/bgp_route.c:2981:
Report for srv6.h | 6 issues
===============================================
< WARNING: line over 80 characters
< #66: FILE: /tmp/f1-10044/srv6.h:66:
< WARNING: line over 80 characters
< #67: FILE: /tmp/f1-10044/srv6.h:67:
< WARNING: line over 80 characters
< #68: FILE: /tmp/f1-10044/srv6.h:68:

NetDEF-CI avatar Jun 06 '22 15:06 NetDEF-CI

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5768/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-5768/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5768/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-5768/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5768/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-5768/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5768/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 4
  • IPv6 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 amd64 part 1
  • Addresssanitizer topotests part 1
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 4
  • Ubuntu 18.04 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 8
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 i386 part 9
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 1
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 arm8 part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 7
  • Fedora 29 rpm pkg check
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 3
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 i386 part 0

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-5768/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5768/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-5768/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5768/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-5768/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5768/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Report for bgp_attr.c | 12 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 40)
< #3640: FILE: /tmp/f1-27623/bgp_attr.c:3640:
< WARNING: line over 80 characters
< #3643: FILE: /tmp/f1-27623/bgp_attr.c:3643:
< WARNING: line over 80 characters
< #3647: FILE: /tmp/f1-27623/bgp_attr.c:3647:
< WARNING: line over 80 characters
< #3702: FILE: /tmp/f1-27623/bgp_attr.c:3702:
< WARNING: line over 80 characters
< #3703: FILE: /tmp/f1-27623/bgp_attr.c:3703:
< WARNING: line over 80 characters
< #4329: FILE: /tmp/f1-27623/bgp_attr.c:4329:
Report for bgpd.c | 2 issues
===============================================
< ERROR: open brace '{' following function declarations go on the next line
< #3878: FILE: /tmp/f1-27623/bgpd.c:3878:
Report for bgp_debug.c | 4 issues
===============================================
< WARNING: suspect code indent for conditional statements (8, 24)
< #470: FILE: /tmp/f1-27623/bgp_debug.c:470:
< WARNING: line over 80 characters
< #472: FILE: /tmp/f1-27623/bgp_debug.c:472:
Report for bgp_mplsvpn.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #1264: FILE: /tmp/f1-27623/bgp_mplsvpn.c:1264:
< WARNING: Missing a blank line after declarations
< #1264: FILE: /tmp/f1-27623/bgp_mplsvpn.c:1264:
< WARNING: line over 80 characters
< #1265: FILE: /tmp/f1-27623/bgp_mplsvpn.c:1265:
< WARNING: line over 80 characters
< #1275: FILE: /tmp/f1-27623/bgp_mplsvpn.c:1275:
< WARNING: line over 80 characters
< #1284: FILE: /tmp/f1-27623/bgp_mplsvpn.c:1284:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2981: FILE: /tmp/f1-27623/bgp_route.c:2981:
Report for srv6.h | 6 issues
===============================================
< WARNING: line over 80 characters
< #66: FILE: /tmp/f1-27623/srv6.h:66:
< WARNING: line over 80 characters
< #67: FILE: /tmp/f1-27623/srv6.h:67:
< WARNING: line over 80 characters
< #68: FILE: /tmp/f1-27623/srv6.h:68:

NetDEF-CI avatar Jun 06 '22 17:06 NetDEF-CI

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5782/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-5782/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5782/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-5782/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5782/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-5782/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5782/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv4 protocols on Ubuntu 18.04
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 arm8 part 0
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Addresssanitizer topotests part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 arm8 part 5
  • Debian 10 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 5
  • Topotests debian 10 amd64 part 1
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 3
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 2
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 7
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 7
  • Addresssanitizer topotests part 3
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 8
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 3
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 9
  • Addresssanitizer topotests part 2
  • Topotests debian 10 amd64 part 9

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-5782/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5782/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-5782/test

Topology Tests failed for Topotests debian 10 amd64 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5782/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-5782/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-5782/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: No useful log found 
Report for bgp_attr.c | 12 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 40)
< #3640: FILE: /tmp/f1-30386/bgp_attr.c:3640:
< WARNING: line over 80 characters
< #3643: FILE: /tmp/f1-30386/bgp_attr.c:3643:
< WARNING: line over 80 characters
< #3647: FILE: /tmp/f1-30386/bgp_attr.c:3647:
< WARNING: line over 80 characters
< #3702: FILE: /tmp/f1-30386/bgp_attr.c:3702:
< WARNING: line over 80 characters
< #3703: FILE: /tmp/f1-30386/bgp_attr.c:3703:
< WARNING: line over 80 characters
< #4329: FILE: /tmp/f1-30386/bgp_attr.c:4329:
Report for bgpd.c | 2 issues
===============================================
< ERROR: open brace '{' following function declarations go on the next line
< #3878: FILE: /tmp/f1-30386/bgpd.c:3878:
Report for bgp_debug.c | 4 issues
===============================================
< WARNING: suspect code indent for conditional statements (8, 24)
< #470: FILE: /tmp/f1-30386/bgp_debug.c:470:
< WARNING: line over 80 characters
< #472: FILE: /tmp/f1-30386/bgp_debug.c:472:
Report for bgp_mplsvpn.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #1264: FILE: /tmp/f1-30386/bgp_mplsvpn.c:1264:
< WARNING: Missing a blank line after declarations
< #1264: FILE: /tmp/f1-30386/bgp_mplsvpn.c:1264:
< WARNING: line over 80 characters
< #1265: FILE: /tmp/f1-30386/bgp_mplsvpn.c:1265:
< WARNING: line over 80 characters
< #1275: FILE: /tmp/f1-30386/bgp_mplsvpn.c:1275:
< WARNING: line over 80 characters
< #1284: FILE: /tmp/f1-30386/bgp_mplsvpn.c:1284:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2981: FILE: /tmp/f1-30386/bgp_route.c:2981:
Report for srv6.h | 6 issues
===============================================
< WARNING: line over 80 characters
< #66: FILE: /tmp/f1-30386/srv6.h:66:
< WARNING: line over 80 characters
< #67: FILE: /tmp/f1-30386/srv6.h:67:
< WARNING: line over 80 characters
< #68: FILE: /tmp/f1-30386/srv6.h:68:

NetDEF-CI avatar Jun 07 '22 15:06 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5813/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for bgp_attr.c | 12 issues
===============================================
< WARNING: suspect code indent for conditional statements (24, 40)
< #3640: FILE: /tmp/f1-5083/bgp_attr.c:3640:
< WARNING: line over 80 characters
< #3643: FILE: /tmp/f1-5083/bgp_attr.c:3643:
< WARNING: line over 80 characters
< #3647: FILE: /tmp/f1-5083/bgp_attr.c:3647:
< WARNING: line over 80 characters
< #3702: FILE: /tmp/f1-5083/bgp_attr.c:3702:
< WARNING: line over 80 characters
< #3703: FILE: /tmp/f1-5083/bgp_attr.c:3703:
< WARNING: line over 80 characters
< #4329: FILE: /tmp/f1-5083/bgp_attr.c:4329:
Report for bgpd.c | 2 issues
===============================================
< ERROR: open brace '{' following function declarations go on the next line
< #3878: FILE: /tmp/f1-5083/bgpd.c:3878:
Report for bgp_debug.c | 4 issues
===============================================
< WARNING: suspect code indent for conditional statements (8, 24)
< #470: FILE: /tmp/f1-5083/bgp_debug.c:470:
< WARNING: line over 80 characters
< #472: FILE: /tmp/f1-5083/bgp_debug.c:472:
Report for bgp_mplsvpn.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #1264: FILE: /tmp/f1-5083/bgp_mplsvpn.c:1264:
< WARNING: Missing a blank line after declarations
< #1264: FILE: /tmp/f1-5083/bgp_mplsvpn.c:1264:
< WARNING: line over 80 characters
< #1265: FILE: /tmp/f1-5083/bgp_mplsvpn.c:1265:
< WARNING: line over 80 characters
< #1275: FILE: /tmp/f1-5083/bgp_mplsvpn.c:1275:
< WARNING: line over 80 characters
< #1284: FILE: /tmp/f1-5083/bgp_mplsvpn.c:1284:
Report for bgp_route.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2981: FILE: /tmp/f1-5083/bgp_route.c:2981:
Report for srv6.h | 6 issues
===============================================
< WARNING: line over 80 characters
< #66: FILE: /tmp/f1-5083/srv6.h:66:
< WARNING: line over 80 characters
< #67: FILE: /tmp/f1-5083/srv6.h:67:
< WARNING: line over 80 characters
< #68: FILE: /tmp/f1-5083/srv6.h:68:

NetDEF-CI avatar Jun 08 '22 16:06 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5814/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for bgp_mplsvpn.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1264: FILE: /tmp/f1-26337/bgp_mplsvpn.c:1264:

NetDEF-CI avatar Jun 08 '22 17:06 NetDEF-CI

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-5817/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for bgp_mplsvpn.c | 2 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1264: FILE: /tmp/f1-9297/bgp_mplsvpn.c:1264:

NetDEF-CI avatar Jun 08 '22 17:06 NetDEF-CI

waiting on @ton31337 's comments before pushing ...

riw777 avatar Jun 19 '22 11:06 riw777

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6906/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for bgp_mplsvpn.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1263: FILE: /tmp/f1-29075/bgp_mplsvpn.c:1263:
< WARNING: line over 80 characters
< #1269: FILE: /tmp/f1-29075/bgp_mplsvpn.c:1269:

NetDEF-CI avatar Aug 13 '22 19:08 NetDEF-CI

waiting on lint errors here ...

riw777 avatar Aug 16 '22 13:08 riw777

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 13 '22 13:10 github-actions[bot]