FRACerqueira
No copyright notice exists for the source code being copied and used
I am tired of pointing out license violations as I have done before, but there is no copyright notice for code copied from my public library (published under the MIT License). This is not in accordance with the MIT License.
I consider the statement "inspired by" to be quite different from a copyright notice. In fact, it is just a copy.
hello. I'll be happy to put the terms you find necessary..... I never had the intention of violating anything... if you look at the code, there is a reference to the origin, it is not a copy, but an evolution. there is a huge difference.... that's why it's an inspiration... anyway what do you want to be cited and where?
You write that you were inspired by the README, but in fact the implementation and testing of EastAsianWidth was simply copied from my original, so why don't you state that and the license in the README?
The EastAsianWidth and base-control was inspired by the work of Sharprompt
Don't forget that you have a history of using my library code almost verbatim and changing only the name to your own work for reasons of of evolution and inspiration.
Hi @shibayan, I'd like to address this since, assumably, it shouldn't be a lot of work, and I don't believe there is negative intent here. People should be credited for their hard work as is needed. "Inspiration" is likely indeed not the right wording here, but I would err on the side of good faith and assume a reason like language barrier.
Since I'm not super familiar with the ins and outs of software licensing, what kind of PR would satisfy the conditions here? Do you have some pointers for me on what to change?
Particularly you mention "a history of using library code"; should more be attributed than just EastAsianWidth from Sharprompt?
@FRACerqueira I notice that FIGlet.Net uses the GNU Affero license, which requires that any works using it must also use the same GNU Affero license as well. May I assume you have used FIGlet.Net code (and perhaps expanded on it) rather than just "being inspired"? In that case that is also a licensing issue, as PromptPlus would have to be a GNU Affero project.
You may re-implement the necessary code yourself so that it's a true inspiration, to avoid this.
Hi @ividyon, I have released the source code of the library under the MIT License, so I see no problem at all in using it.
However, I believe that the use of the word "Inspired" and the absence of a license notice in the README shows disrespect for the original library and its license.
In essence, you are asking that the README state the license and that you are using the code. The words Inspired or Evolution would be inappropriate in that context.
As I mentioned in one previous comment, I don't feel any respect for the original library. That would be the fundamental issue.
@FRACerqueira I notice that FIGlet.Net uses the GNU Affero license, which requires that any works using it must also use the same GNU Affero license as well. May I assume you have used FIGlet.Net code (and perhaps expanded on it) rather than just "being inspired"? In that case that is also a licensing issue, as PromptPlus would have to be a GNU Affero project.
You may re-implement the necessary code yourself so that it's a true inspiration, to avoid this.
I notice that library provides fairly minor benefits to PromptPlus, and is also a rewrite of a previous library which is under MIT:
https://github.com/auriou/FIGlet
Might be prudent to use that one instead.
@ividyon , Sorry for the delay, I was out of the office (Vacation). You did a great job on copyright. I intend to adapt the MIT version of "FIGlet" to PromptPlus following the same copyright notice model made by you.
A commit to release v4.0.5 was performed on this issue.
@shibayan , I hope this is in line with the licensing wishes that have been requested.
Updated (19/10): Your EastAsia Width code (AND your tests) is being removed in the expected version (4.2.0)
If you still have another wish on this subject, or find a copy of code that does not mention your copywrite, just let us know and we will mention it accordingly. Thank you for contributing to the improvements!
Hi @ividyon ! I hope you enjoyed the latest improvements.
I also think it is closed, but I am keeping it open with the tag "Closed issue" out of respect for the person who originated this issue to say that they agree or report any other changes that they do not agree with.