LicenseCheck icon indicating copy to clipboard operation
LicenseCheck copied to clipboard

Draft: Support for unix pattern in packages

Open LSerranoPEReN opened this issue 1 year ago • 0 comments

Purpose of This Pull Request

Please check the relevant option by placing an "X" inside the brackets:

  • [ ] Documentation update
  • [ ] Bug fix
  • [x] New feature
  • [ ] Other (please explain):

Overview of Changes

This MR adds Unix pattern support for ignored packages.

I have a very concrete case where I use Nvidia deep learning packages in a project, that come with a proprietary license that I know is compatible with my project, so each of the packages is marked as ignored in my pyproject file.

Since all Nvidia packages in my project have the same pattern (nvidia-cublas-cu11, nvidia-cuda-cupti-cu11, etc.), I wanted to compact the ignore-package section a bit. This MR enables to declare nvidia-*-cu11 as ignored, using Unix style patterns and fnmatchcase function.

Reviewer Focus

This MR is a draft, but I tested that the feature was working in my project. I wanted to know if this was a good idea or not before maybe adding this feature to other sections, like maybe fail-packages, and adding tests and documentation.

Additional Notes

I'm using Unix patterns instead of regexes for the sake of simplicity, but I am open to use regexes instead if needed.

LSerranoPEReN avatar Aug 29 '24 09:08 LSerranoPEReN