dolfinx icon indicating copy to clipboard operation
dolfinx copied to clipboard

Unpin cffi from version < 1.17

Open schnellerhase opened this issue 1 year ago • 1 comments

The release of cffi version v1.17.0 broke the red hat CI pipeline.

An explicit downgrade as hot fix was introduced in https://github.com/FEniCS/dolfinx/pull/3339. This should be reverted, to using the latest version of cffi in its runs, to fix this issue.

Interestingly this seems to be a platform dependent problem as the other CI runs did not reproduce the behavior.

schnellerhase avatar Aug 07 '24 11:08 schnellerhase

Unpin once https://github.com/python-cffi/cffi/pull/111 is in cffi release.

See also https://github.com/python-cffi/cffi/pull/127.

garth-wells avatar Oct 02 '24 06:10 garth-wells

Just a heads up that on my Debian testing system cffi<1.17 failed to compile from source with python 3.13, while cffi==1.17 works fine (and is already packaged). The pin should ideally be gone before our next release if at all possible (meaning, if cffi does have a new release in the meantime).

francesco-ballarin avatar Feb 13 '25 08:02 francesco-ballarin

We should unpin cffi now, and raise an exception if a user tries to use it with a complex type (and advise them to rollback cffi).

garth-wells avatar Feb 13 '25 08:02 garth-wells