fa icon indicating copy to clipboard operation
fa copied to clipboard

SACU Base Stat Chanages

Open MrRowey opened this issue 1 year ago • 2 comments

This is the same stats that were Approved before hand but now that their a new lead here is a new PR for all this

# Aeon
Health: 15000 > 11500 (-23%)
Regen: 17 > 14 (-17%)
EnergyCost: 27100 > 21450 (-21%)
MassCost: 1950 > 1650 (-15%)
BuildRate: 56 > 40 (-29%)
BuildTime: 14400 > 11500 (-20%)
Damage: 300 > 100 (-66%)
Range: 30 >25 (-17%)

# UEF
Health: 16000 > 13000 (-18%)
Regen: 20 > 16 (-20%)
EnergyCost: 25200 > 21450 (-15%)
BuildRate: 56 > 40 (-29%)
BuildTime: 14400 > 11500 (-20%)
Damage: 300 > 100 (-66%)

# Cybran
Health: 19000 > 12500 (-34%)
Regen: 25 > 21 (-16%)
EnergyCost: 26400 > 21450 (-19%)
BuildRate: 56 > 40 (-29%)
BuildTime: 14400 > 11500 (-20%)
Damage: 300 > 100 (-66%)

# Sera
Health: 15500 > 12000 (-23%)
Regen: 15 > 12 (-20%)
EnergyCost: 30200 > 21450 (-29%)
BuildRate: 56 > 40 (-29%)
BuildTime: 14400 > 11500 (-20%)
Damage: 300 > 100 (-66%)
EnergyProduction: 300 > 100 (-66%)
MassProduction: 3 > 1 (-66%)
Damage: 400> 100 (-75%)

Checklist

  • [ ] Changes are annotated, including comments where useful
  • [ ] Changes are documented in the changelog for the next game version

MrRowey avatar Oct 22 '24 20:10 MrRowey

If im not mistaken, looking at this along with the upgrade changes results in reduced dps. Is that intended?

RabidPope avatar Oct 24 '24 07:10 RabidPope

If im not mistaken, looking at this along with the upgrade changes results in reduced DPS. Is that intended?

The base SACU is to have more minimal stats than the upgrade, which gives them the desired traffic. Enhancements are all still Subject to Change but this was previsouled what was accepted at the beginning of the year so just a new PR for it.

The BT will start discussing this actively once the backlog of Other balance-related PR is dealt with.

MrRowey avatar Oct 24 '24 15:10 MrRowey

@lL1l1 this can be merged

MrRowey avatar Nov 18 '24 21:11 MrRowey

This PR doesn't include the changes themselves? They're from #6302 which already has a snippet in balance.6301.md.

lL1l1 avatar Nov 20 '24 02:11 lL1l1

Hmm something may have got mixed up then

MrRowey avatar Nov 21 '24 13:11 MrRowey

Please do not merge this right now, wait a few days until after the release is stable. If I am not mistaken then @Rhaelya wants these changes on FAF Beta Balance, and not in the major release of tomorrow.

Garanas avatar Nov 21 '24 15:11 Garanas

This PR points at FAForever:feature/SACU-Rebalance

lL1l1 avatar Nov 21 '24 17:11 lL1l1

Yes its not supposed to be in the major release, its supposed to be in a mod and possibly faf beta, only to be merged once the changes have been tested so perhaps earliest in the first release of 2025.

Rhaelya avatar Nov 21 '24 19:11 Rhaelya

Ive updated both my reviews on this and the #6489 to state they are not supposed to be merged currently. Perhaps the "do not merge" tag could be applied to make sure?

Rhaelya avatar Nov 21 '24 19:11 Rhaelya

@MrRowey maybe its best to create a new branch and cherry pick the necessary commits there? This branch behaves badly on github desktop when I try to update it, and I end up using git gui.

lL1l1 avatar Nov 22 '24 05:11 lL1l1

Ive updated both my reviews on this and the #6489 to state they are not supposed to be merged currently. Perhaps the "do not merge" tag could be applied to make sure?

At the top of the page it says

MrRowey wants to merge 6 commits into FAForever:feature/SACU-Rebalance from MrRowey:SCU-Base-Stats

it means that this is being merged into the feature/SACU-Rebalance branch. Faf develop and faf beta are automatically updated from the develop branch, so merging this PR won't affect what is deployed to faf develop or faf beta. I think this branch is just being used to stack the various SACU PRs before they all get merged together into develop.

lL1l1 avatar Nov 22 '24 08:11 lL1l1

@lL1l1 yeh probs best to do a new branch. would you be able to create a new branch for me so I can change the PR merge too

MrRowey avatar Nov 22 '24 12:11 MrRowey

@MrRowey I have created the new branch: feature/SACU-Rebalance2

lL1l1 avatar Nov 24 '24 00:11 lL1l1

@lL1l1 I've moved this to the new branch so can me merged

MrRowey avatar Nov 24 '24 18:11 MrRowey