fa icon indicating copy to clipboard operation
fa copied to clipboard

Add new event when ACU enters transporter.

Open rigomate opened this issue 2 years ago • 3 comments

As seen in the discord suggestion channel, this could be a handy event for casters. Whenever an ACU is put into a transport, there is likely some action going to take place. So getting notified about this when casting could put the caster in the middle of the action.

The event is only created for replays, as it needs to be hidden from the enemy team.

rigomate avatar Apr 02 '23 20:04 rigomate

You'd also have to put some changes in UserSync.lua

Can you elaborate why that would be necessary? I could just hook into this with a mod to get access to the information. Like here: https://github.com/rigomate/SupremeScoreBoard/blob/17055f312a8c652eda145946ddeca90482dd9f8e/hook/lua/UserSync.lua#L39

Thanks!

rigomate avatar Apr 03 '23 21:04 rigomate

Observer is better than hooking, and we want to move towards using observers.

4z0t avatar Apr 03 '23 23:04 4z0t

Observer is better than hooking, and we want to move towards using observers.

Ok, I will look into that, and modify the pull request. Is there maybe a pointer for me for an existing pattern?

rigomate avatar Apr 04 '23 18:04 rigomate