F4HTB
Added NETRIGCTL support
Added the ability for the UI to use a NETRIGCTL based radio instead of only serial
Hello Dear, Thanks for contribute to UHRR project. Thank you for your patience; I didn't have much time for the code review.
A few remarks, however: -It looks like you handled the connection selection code well. Could you please confirm that the switch from net to serial is working correctly?
if (config['HAMLIB']['rig_connection'] == "serial"): .....
if (config['HAMLIB']['rig_connection'] == "net"):.....
-It seems that the use of CDVALUE is unnecessary. Could you try something like:
if(config['HAMLIB']['rig_rigctld_path']!=""):
self.write("""HAMLIB NETRIGCTL Server:<input type="text" name="HAMLIB.rig_rigctld_path" value="""+config['HAMLIB']['rig_rigctld_path']+"""> Use IP.ip.IP.ip:PORT format ex. 192.168.1.1:4533<br/><br/>""")
-Also, in UHRR.conf, the original conf file should be kept to maintain the more common default serial mode.
No worries. I apologize for my multiple pull requests I had messed up some things with my account and was straightening them out.
As the code stands I've tested it with a NETRIGCTL radio and it works. I do not have a serial radio attached to the test machine to confirm the serial side works for sure but I've toggled it to serial and it tries to do a serial connection.
I'll try the code in place of the CDVALUE bit.
UHRR.conf makes sense to set it to serial. I'll adjust that. Clearly I was testing the netrigctl settings.