gHomes icon indicating copy to clipboard operation
gHomes copied to clipboard

Refactor: Convert array-like tables to hashtables

Open google-labs-jules[bot] opened this issue 3 months ago • 1 comments

This pull request refactors the addon to use hashtables for lists that are frequently searched, significantly improving performance. The primary changes are:

  • Converted the friends table from an array to a hashtable, replacing inefficient table.HasValue calls with direct key lookups.
  • Implemented a data migration function to seamlessly transition existing save data to the new format.
  • Removed the redundant friendsname table, as the UI can now dynamically generate friend names.
  • Added extensive nil-safety checks to prevent errors when a house has no friends list.
  • Created a shared utility function, ghomes.utils.arrayToHashtable, to handle the conversion.

These changes will reduce server load and improve the overall user experience by making the addon more responsive.


PR created automatically by Jules for task 12350407595810257628

google-labs-jules[bot] avatar Nov 03 '25 07:11 google-labs-jules[bot]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules[bot] avatar Nov 03 '25 07:11 google-labs-jules[bot]