react-native-live-markdown icon indicating copy to clipboard operation
react-native-live-markdown copied to clipboard
verified publisher icon Expensify

Improve performance on iOS

Open maksg opened this issue 1 year ago • 3 comments

Details

On iOS TextView was very slow and unreliable. This PR improves the performance by quite a lot by removing some unnecessary code and simplifying parsing logic.

maksg avatar May 23 '24 17:05 maksg

This PR fixes an issue with fontSize and emoji.fontSize not being applied right-away on iOS:

https://github.com/user-attachments/assets/24762c03-6e8f-42ea-81d7-c35f0b28c02f

tomekzaw avatar Sep 12 '24 09:09 tomekzaw

❌ Regression found: text suggestions are instantly converted into regular text

https://github.com/user-attachments/assets/516bfe9e-9f24-4840-85f1-01c114e54150

tomekzaw avatar Sep 12 '24 09:09 tomekzaw

Regression found:

https://github.com/user-attachments/assets/a3f84ba2-5cb5-45bf-88f5-622c583590e9

tomekzaw avatar Sep 18 '24 07:09 tomekzaw

Fixed all the issues except this. Possibly it's a regression but needs to be looked at. I think it happens only after emojis because other than that the autocomplete seems to work.

https://github.com/user-attachments/assets/694d8cdc-10e0-433a-8e97-810c52458d45

maksg avatar Oct 14 '24 15:10 maksg

Closing this PR as #520 has just been merged.

Thanks @maksg for showing me this approach with modifying NSTextStorage in-place.

tomekzaw avatar May 14 '25 20:05 tomekzaw