Bedrock Does not compile on Fedora 26

Bedrock does not compile on Fedora 26 (and there is no compiled rpm). The problem seems to be that Fedora 26 ships only with g++-7 /c++-17, and the Bedrock code seems not compatible with this new standard.

Nov 04 '17 08:11 stephancb

I fixed the issues related to gcc7 on the archlinux PKGBUILD by patching the sources as follows:

sed -i "s|#include <atomic>|#include <atomic>\n#include <functional>|" \
  libstuff/libstuff.h

sed -i "s|/mbedtls/include -Werror -Wno-unu|/mbedtls/include -Wno-unu|" \
  Makefile

sed -i 's|"Timestamp"), 1ul)|"Timestamp"), 1ull)|' \
  libstuff/STCPNode.cpp

Feb 07 '18 07:02 jgmdev

I just noticed this one:

sed -i 's|"Timestamp"), 1ul)|"Timestamp"), 1ull)|' \
  libstuff/STCPNode.cpp

Is only needed on arm (at leat armv7h in my case), in x64 it should compile without it

Feb 09 '18 16:02 jgmdev

Should these patches not be added @quinthar?

Aug 15 '18 06:08 wmertens

Ah, sounds great! Can you or @jgmdev submit a PR? Thanks!

Aug 15 '18 06:08 quinthar

@jgmdev, do you want to make the PR? If not, or if I don't hear from you by next week, I'll do it.

On Wed, Aug 15, 2018 at 8:34 AM David Barrett [email protected] wrote:

Ah, sounds great! Can you or @jgmdev https://github.com/jgmdev submit a PR? Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Expensify/Bedrock/issues/320#issuecomment-413107076, or mute the thread https://github.com/notifications/unsubscribe-auth/AADWlivlumJbxhyr_3DVuBXsM0wVZjjbks5uQ8DpgaJpZM4QR7ij .

Aug 15 '18 06:08 wmertens