App icon indicating copy to clipboard operation
App copied to clipboard

Email - No Invitation email sent to mailbox after user invite new user to Room

Open jponikarchuk opened this issue 1 month ago • 16 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.2.75-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176726/test-cases/41237090 https://github.com/Expensify/App/pull/75778 Email or phone of affected tester (no customers): na Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: Web App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new account.
  3. Select Manage my team then continue with the onboarding flow
  4. Click FAB >> Start Chat >> Room >> Enter Room name >> Create Room
  5. User is directed to the created Room >> Click header >> Member >> Invite non-existing member to the room
  6. On the whisper>> Select invite to chat only (observe that the member is displayed in the Member list)
  7. Open the mailbox and wait for email to arrive (user wait for more than 10 minutes)

Expected Result:

an invitation was sent to the new user’s inbox, then user click on the bottom link and it will directed to the room page

Actual Result:

There is no an invitation was sent to the new user’s inbox

Note: On production, the email invitation sent immediately upon invite member to the room, also there is no whisper message to select

Workaround:

Unknown

Platforms:

  • [ ] Android: App
  • [ ] Android: mWeb Chrome
  • [ ] iOS: App
  • [ ] iOS: mWeb Safari
  • [ ] iOS: mWeb Chrome
  • [x] Windows: Chrome
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/48a15a6f-fecf-4796-8236-a4632e6a398e

View all open jobs on GitHub

jponikarchuk avatar Dec 11 '25 08:12 jponikarchuk

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 11 '25 08:12 melvin-bot[bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Dec 11 '25 08:12 melvin-bot[bot]

💬 A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Dec 11 '25 08:12 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Dec 11 '25 08:12 github-actions[bot]

Discussing in https://expensify.slack.com/archives/C01GTK53T8Q/p1765446030757489?thread_ts=1765442295.315359&cid=C01GTK53T8Q

MonilBhavsar avatar Dec 11 '25 09:12 MonilBhavsar

No whisper message from Concierge, MacOS Monterey / Chrome, Web v9.2.75-0 PR:77353

https://github.com/user-attachments/assets/83bada79-5b45-4c59-ad37-6c0caddbfa67

m-natarajan avatar Dec 11 '25 12:12 m-natarajan

Thanks, not a blocker as email is also not sent when inviting user through whisper on prod

MonilBhavsar avatar Dec 11 '25 12:12 MonilBhavsar

Charly is reviewing and will get to soon

mallenexpensify avatar Dec 12 '25 20:12 mallenexpensify

Hey @garrettmknight @parasharrajat I don't think we should be triggering the whisper in these rooms when adding members to the room in that flow, could you look at the video in the description and tell me if you agree? I went back and looked at this comment where we said to only trigger this in expense chats. I imagine that should also fix the email issue.

carlosmiceli avatar Dec 13 '25 02:12 carlosmiceli

I think the backend flow to send emails might be the same for all types of chats, rooms, or workspace chat. Can you please confirm that?

But in any case, I would say that keeping the same behaviour is better; otherwise, it might be confusing to users as to why one type of chat has a different invite flow, and the other has a different one.

Or we can just revert this change if there are many complications. Instead, we can add 2 buttons on the invite confirm page, Invite to chat and Invite to submit expenses. The invite to chat will use the same flow as usual, and we need to handle the invite to submit expenses.

parasharrajat avatar Dec 13 '25 11:12 parasharrajat

I'd defer to what @garrettmknight decides here, but I don't think Invite to submit expenses should be a default option in an invite to a room whisper (as in, I don't think the whisper is necessary in these invite flows, user should be invited to chat and that's it). The new multiple option whisper was specifically aimed at expense chats because of its potentially confusing nature of whether you want someone to submit expenses or just to include them in the conversation.

carlosmiceli avatar Dec 13 '25 17:12 carlosmiceli

@carlosmiceli, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 17 '25 00:12 melvin-bot[bot]

@garrettmknight , 👀 above when you have a min, thx

mallenexpensify avatar Dec 17 '25 00:12 mallenexpensify

@carlosmiceli, @mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Dec 23 '25 00:12 melvin-bot[bot]

@garrettmknight bump 🫶

carlosmiceli avatar Dec 23 '25 00:12 carlosmiceli

@carlosmiceli @mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 25 '25 21:12 melvin-bot[bot]

Hey @parasharrajat seems like Garrett is gonna be OOO for a while, let's for now proceed with this fix for now: https://github.com/Expensify/App/issues/77336#issuecomment-3648749970

cc @mallenexpensify thought I'd make a call here, sounds good?

carlosmiceli avatar Dec 26 '25 22:12 carlosmiceli