[Due for payment 2025-12-25][$250] Connected Cards - App crashes when adding to Apple/Google wallet in Classic

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.2.63-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2159/folder/13176890/41237391/1035954283 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: iPhone 14 / iOS 26.1 App Component: User Settings

Action Performed:

1. User has logged in Hybrid app with Expensifail account
2. Navigate to Troubleshoot in account settings
3. Tap on the Switch to Expensify Classic
4. Tap on the Hamburger menu and select Settings
5. Tap on Connected Cards
6. Tap on the Add to Apple/Google Wallet button
7. Tap on the Turn it on button

Expected Result:

The app goes to the 2FA flow

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

• [x] Android: App
• [ ] Android: mWeb Chrome
• [x] iOS: App
• [ ] iOS: mWeb Safari
• [ ] iOS: mWeb Chrome
• [ ] Windows: Chrome
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/43d3e7bd-0283-4258-aec9-acdc3e0f8f23

logs.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993291282052216766
• Upwork Job ID: 1993291282052216766
• Last Price Increase: 2025-11-25
• Automatic offers:
• abzokhattab | Contributor | 109668374
• dominictb | Contributor | 109670882

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot[bot]]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021993291282052216766

[zanyrenney]

key revenue generating flow.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @FitseTLT (External)

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when adding to Apple/Google wallet in Classic

What is the root cause of that problem?

The _saveAndLeave function here is not defined anywhere causing the crash.

It's supposed to dismiss the modal but was renamed to onExit from this PR. But the above instance was not updated accordingly.

What changes do you think we should make in order to solve the problem?

Replace with NavigationManager.getInstance().dismissModal();.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot[bot]]

@FitseTLT Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@FitseTLT Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[abzokhattab]

Thanks @dominictb, your proposal is correct 👍

:ribbon: :eyes: :ribbon: C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[dominictb]

@francoisl PR is here https://github.com/Expensify/Mobile-Expensify/pull/13791. Can you run adhoc build and assign @abzokhattab as reviewer?

[francoisl]

Done

[melvin-bot[bot]]

@francoisl Whoops! This issue is 2 days overdue. Let's get this updated quick!

[abzokhattab]

PR is ready its on my list .. will review it in the morning

[zanyrenney]

OOO until Friday 12th, adding bug buddy.

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

@francoisl @trjExpensify @abzokhattab @dominictb this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@francoisl Whoops! This issue is 2 days overdue. Let's get this updated quick!

[francoisl]

Not overdue – blocked on this internal issue to finish testing.

[trjExpensify]

@zanyrenney is back, dropping myself off.

[melvin-bot[bot]]

@francoisl Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[francoisl]

The fix was deployed to production yesterday, going to reassign the issue owner for payment.

[abzokhattab]

BugZero Checklist:

• [ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: NA 

• [ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [ ] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Account is using OldDot (Troubleshoot > Switch to Expensify Classic if needed)
• Account has not enabled 2FA
• Account has a virtual Expensify card

Test:

1. In OldDot, tap on the Hamburger menu and select Settings
2. Tap on Connected Cards
3. Tap on the Add to Apple Wallet/Google Pay button
4. Tap on the Turn it on button
5. Verify app does not crash

Do we agree 👍 or 👎

[melvin-bot[bot]]

@zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@zanyrenney Eep! 4 days overdue now. Issues have feelings too...