App
App copied to clipboard
Expensify
Multiple workflows being created when the default approver is changed to a non-admin
cc @aldo-expensify
Note: I was unable to reproduce this on staging, I could only reproduce it locally.
Action Performed:
- Create a workspace as User A
- Invite User B and User C to the workspace
- Go to more settings
- Turn on workflows
- Go to workflows
- Turn on Add Approvals
- Select the first workflow and change the approver from User A to User B
Expected Result:
There should only be a single workflow with User B as the approver
Actual Result:
There are two workflows. One with User B as the approver and one with User A as the approver.
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/51acef0d-1acc-4eb8-aed4-f2ca272083b4
Daily Update
- I created an Auth PR to fix this
- I had to create a bedrock PR as well to add some logging params
Next Steps
- Get both PRs reviewed and merged
ETA
- Finished by tomorrow, Dec 5
Daily Update
- The Bedrock PR was merged
- The Auth PR is still under review and the tests are passing
Next Steps
- @aldo-expensify Review and merge https://github.com/Expensify/Auth/pull/13426
ETA
- Monday, Dec 9
Daily Update
- The Auth PR is in final stages of review
Next Steps
- @aldo-expensify and @youssef-lr review and merge https://github.com/Expensify/Auth/pull/13426
ETA
- Today, Dec 9
Daily Update
- https://github.com/Expensify/Auth/pull/13426 was merged and deployed to production