Expensify
[$125] Show pinned selfDM only to those users with "introSelected" for Track -- NVP: newDotPersonalSpend
As a follow up to this issue, we're also going to remove the selfDM being pinned and in the LHN for all users going forward unless they have selected the Track case and have the Track intention NVP: newDotPersonalSpend
We currently show it to users who select this intention:
- Get paid back from my employer case
- Split and chat with friends
- Something else
And we also pin it by default for users without an intention. We want to remove all these cases.
So in summary, only users who select the Track intention should ever have the SelfDM pinned to their LHN by default when this issue is done.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021866165206858103237
- Upwork Job ID: 1866165206858103237
- Last Price Increase: 2024-12-10
- Automatic offers:
- suneox | Reviewer | 105265880
Issue Owner
Current Issue Owner: @
Job added to Upwork: https://www.upwork.com/jobs/~021866165206858103237
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Current assignee @suneox is eligible for the External assigner, not assigning anyone new.
@suneox @nkdengineer since you all worked on this one, I assume you can also help complete this one quickly as a follow on? @MonilBhavsar can help if needed with anything.
@danielrvidal I can help to check and have a solution tomorrow, please help to assign me here.
📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
❌ There was an error making the offer to @nkdengineer for the Contributor role. The BZ member will need to manually hire the contributor.
This is probably just one word change given we introduced the logic in the previous PR. Going to adjust the price to $125. @danielrvidal feel free to update it if you think otherwise.
@danielrvidal So what is the expected here?
- When the user signs in the first time, the selfDM will not be pinned by default.
- If the user selects track NVP
newDotPersonalSpend, the selfDM will be pinned.
Or
- When the user signs in the first time, the selfDM will be pinned by default.
- If the user doesn't select
newDotPersonalSpend, unpin the selfDM.
It would be Option 1, sorry for the delay! We don't want them to know it exists unless they select the Track flow so we don't want it showing up before they select that.
It would be Option 1, sorry for the delay! We don't want them to know it exists unless they select the Track flow so we don't want it showing up before they select that.
@MonilBhavsar Based on this, we need to update the backend side to change isPinned of the selfDM to false when we create a new account and when we complete the onboarding flow with newDotPersonalSpend we update isPinned to true.
Great! @danielrvidal We must wait for the backend change before moving forward with the frontend PR.
I think you can have a draft up, and then we can test it once backend is done?
Hey team, can we expect a PR for this today? This is a blocker for migrating cohort 1, which we plan to do next week!
@danielrvidal @flaviadefaria I was thinking how does this work with migrating users? They won't see the guided setup modal. So should we keep self DM for them?
No, they should not see it. We only want to show it if the user explicitly selects the chat option.
Thank you! So to sum it up.
For any new/migrated users self DM won't be showed to the users. When new users sign up on newDot, we display them onboarding modal and if they select "Track expenses", we would only display and pin self DM. Does that sound correct?
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
@nkdengineer what do you think of this comment https://github.com/Expensify/App/issues/53405#issuecomment-2536213377 Please let us know. This is top priority issue currently
@MonilBhavsar I'm preparing the draft locally but we cannot test now because the selfDM is pinned by default.
Agree! But would be good to keep it prepared, so we can merge when backend is deployed, mostly on Monday