App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Hybrid - iOS - Split - "User split $0" notifications received when user split expense via scan, iOS Hybrid app crashes

Open IuliiaHerets opened this issue 1 year ago β€’ 7 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.68-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5275241 Issue reported by: Applause Internal Team

Action Performed:

Preconditions: User A signed in in Desktop app, User B in iOS Hybrid app, User C in Web.

  1. As User A navigate to staging.new.expensify desktop app.
  2. Create a group chat with users B and C.
  3. In the group chat click "+" button, Split expense, Scan.
  4. Click Choose file and select pdf or png receipt.
  5. Split expense, verify the receipt is in scanning status.

Expected Result:

Users B and C do not receive "User A split $0" notifications while the receipt is scanning, iOS Hybrid app does not crash.

Actual Result:

Users B and C receive "User A split $0" notifications while the receipt is scanning, iOS Hybrid app crashes.

Workaround:

Unknown

Platforms:

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [x] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

2911_1.txt

https://github.com/user-attachments/assets/08865009-f80d-45f1-8192-b6d135cf45cf

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864470651196859868
  • Upwork Job ID: 1864470651196859868
  • Last Price Increase: 2024-12-05
Issue OwnerCurrent Issue Owner: @eVoloshchak

IuliiaHerets avatar Nov 29 '24 09:11 IuliiaHerets

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Nov 29 '24 09:11 melvin-bot[bot]

@VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 02 '24 10:12 melvin-bot[bot]

I haven't had a chance to look at this yet, but will do today

VictoriaExpensify avatar Dec 03 '24 00:12 VictoriaExpensify

Job added to Upwork: https://www.upwork.com/jobs/~021864470651196859868

melvin-bot[bot] avatar Dec 05 '24 00:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

melvin-bot[bot] avatar Dec 05 '24 00:12 melvin-bot[bot]

@eVoloshchak, @VictoriaExpensify Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Dec 10 '24 09:12 melvin-bot[bot]

Not overdue, this is awaiting proposals

eVoloshchak avatar Dec 10 '24 12:12 eVoloshchak

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Dec 12 '24 16:12 melvin-bot[bot]

@eVoloshchak @VictoriaExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 13 '24 09:12 melvin-bot[bot]

@eVoloshchak, @VictoriaExpensify Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Dec 16 '24 09:12 melvin-bot[bot]

Not overdue, this is awaiting proposals

eVoloshchak avatar Dec 16 '24 21:12 eVoloshchak

I think the push notification should be fixed on the BE side. Here is an example about the push notification payload:

{
  "pushPayload": {
    "title": "123123 in 123123, truphd01+1002, [email protected]",
    "alert": "split β‚«0",
    "extras": {
      "com.urbanairship.title": "123123 in 123123, truphd01+1002, [email protected]",
      "com.urbanairship.notification_channel": "1443339497863742",
      "com.urbanairship.push.ALERT": "split β‚«0",
      "com.urbanairship.push.PUSH_ID": "41f88065-bde5-11ef-8cd5-02425ea0ca56",
      "payload": {
        "type": "moneyRequest",
        "title": "123123 in 123123, truphd01+1002, [email protected]",
        "onyxData": [
          {
            "key": "report_1443339497863742",
            "onyxMethod": "merge",
            "value": {
              "chatType": "group",
              "description": "",
              "lastActorAccountID": 18852838,
              "lastMessageText": "split β‚«0",
              "lastVisibleActionCreated": "2024-12-19 08:42:57.618",
              "managerID": null,
              "ownerAccountID": 0,
              "parentReportActionID": null,
              "parentReportID": null,
              "policyID": "_FAKE_",
              "reportID": "1443339497863742",
              "reportName": "",
              "state": "OPEN",
              "stateNum": 0,
              "statusNum": 0,
              "type": "chat",
              "visibility": null
            }
          },
          {
            "key": "reportActions_1443339497863742",
            "onyxMethod": "merge",
            "shouldShowPushNotification": true,
            "value": {
              "3632765990272408978": {
                "actionName": "IOU",
                "actorAccountID": 18852838,
                "avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_23.png",
                "created": "2024-12-19 08:42:57.618",
                "lastModified": "2024-12-19 08:42:57.618",
                "message": [
                  {
                    "html": "split β‚«0",
                    "text": "split β‚«0",
                    "type": "COMMENT",
                    "whisperedTo": []
                  }
                ],
                "originalMessage": {
                  "IOUTransactionID": "5431236517416942070",
                  "amount": 0,
                  "comment": "",
                  "currency": "VND",
                  "isNewDot": true,
                  "lastModified": "2024-12-19 08:42:57.618",
                  "participantAccountIDs": [17924662, 18834150, 18852838],
                  "type": "split"
                },
                "person": [
                  {
                    "style": "strong",
                    "text": "123123",
                    "type": "TEXT"
                  }
                ],
                "reportActionID": "3632765990272408978",
                "shouldShow": true
              }
            }
          }
        ],
        "previousUpdateID": 3488818789,
        "lastUpdateID": 3488827401,
        "reportID": "1443339497863742",
        "reportActionID": "3632765990272408978",
        "roomName": "",
        "app": "new"
      },
      "com.urbanairship.push.CANONICAL_PUSH_ID": "40d6e3c0-bde5-11ef-8bbf-0000a1ace0f5",
      "com.urbanairship.priority": "high",
      "com.urbanairship.push.APID": "e1ae76b5-72a9-41cd-afdf-8c3ec5806f07",
      "com.urbanairship.metadata": {
        "version_id": 1,
        "time": 1734597782374,
        "push_id": "40d6e3c0-bde5-11ef-8bbf-0000a1ace0f5",
        "campaigns": {
          "categories": []
        },
        "context": {}
      }
    }
  }
}

truph01 avatar Dec 19 '24 08:12 truph01

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Dec 19 '24 16:12 melvin-bot[bot]

@eVoloshchak, @VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 20 '24 09:12 melvin-bot[bot]

@eVoloshchak, @VictoriaExpensify Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Dec 24 '24 09:12 melvin-bot[bot]

@eVoloshchak, @VictoriaExpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] avatar Dec 26 '24 09:12 melvin-bot[bot]

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Dec 26 '24 16:12 melvin-bot[bot]

@eVoloshchak @VictoriaExpensify this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Dec 27 '24 09:12 melvin-bot[bot]

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Dec 30 '24 04:12 mvtglobally

@eVoloshchak, @VictoriaExpensify 12 days overdue now... This issue's end is nigh!

melvin-bot[bot] avatar Dec 30 '24 09:12 melvin-bot[bot]

This issue has not been updated in over 14 days. @eVoloshchak, @VictoriaExpensify eroding to Weekly issue.

melvin-bot[bot] avatar Jan 02 '25 09:01 melvin-bot[bot]

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Jan 02 '25 16:01 melvin-bot[bot]

Can't be reproduced:

Uploading ScreenRecording_01-09-2025 11-03-42_1.MP4…

I'm going ahead and closing this out

VictoriaExpensify avatar Jan 08 '25 22:01 VictoriaExpensify

Issue is still reproducible on the latest build 9.0.88-6

The steps to reproduce are here:

  1. As User A navigate to staging.new.expensify in mWeb/Safari
  2. Create a group chat with users B
  3. In the group chat click "+" button, Split expense, Manual
  4. User A recieves a nontification
  5. User B click on IOS nontification

https://github.com/user-attachments/assets/0d1da2c8-6971-415b-a594-03fc977b9cdf

lanitochka17 avatar Jan 22 '25 20:01 lanitochka17

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Mar 05 '25 16:03 melvin-bot[bot]

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Mar 12 '25 16:03 melvin-bot[bot]

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Mar 15 '25 00:03 mvtglobally

I can't repro and neither can @mvtglobally. @lanitochka17 can you still repro?

VictoriaExpensify avatar Mar 17 '25 03:03 VictoriaExpensify

User, B signed in on iOS Hybrid, still receives "User A split $0.00" notification, but the app does not crash. Version 9.1.14-0

https://github.com/user-attachments/assets/0001ad4f-ba88-4f57-be80-db28e90c0dc9

lanitochka17 avatar Mar 17 '25 18:03 lanitochka17

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Mar 19 '25 16:03 melvin-bot[bot]