Expensify
[HOLD for payment 2024-12-17] Add `Posted:` for filtering card transactions by statement dates
We missed adding this filter in the Search v2 design doc, so let's add it now. Like other date filters, it'll accept YYYY-MM-DD and will apply exclusively to the Expensify Card.
Issue Owner
Current Issue Owner: @JmillsExpensify
Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:
Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)
@JmillsExpensify will datePosted: accept both before and after values like our regular date filter?
Hmm, good question. We should probably take that approach for consistency.
@JmillsExpensify should this filter name also follow the other date-based filter and be just posted: instead of datePosted:? We are using submitted, approved, etc for the other ones
Also see this comment from a related issue. We're getting to the point that we have a ton of filters that do different things, so it's a good time to section out the options into thematic sections.
@luacmartins I don't see Posted in that list of filters—am I just missing something?
@dannymcclain do you have a card added to the account? The card and posted filters only show up when you have a card associated with that account
Ah gotcha—I was just going by what I was seeing in the videos in the PR. Sounds like it's taken care of though! Thanks!
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.73-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/52938
If no regressions arise, payment will be issued on 2024-12-17. :confetti_ball:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@luacmartins] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [ ] [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
@JmillsExpensify, @dannymcclain, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@JmillsExpensify, @dannymcclain, @luacmartins Still overdue 6 days?! Let's take care of this!
@JmillsExpensify, @dannymcclain, @luacmartins 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
@JmillsExpensify, @dannymcclain, @luacmartins 12 days overdue. Walking. Toward. The. Light...
Payment was handled via https://github.com/Expensify/App/issues/52262. Closing.