Expensify
[HOLD for payment 2024-12-07] [$125] Update the intent video for `Get paid back from my employer`
Update the intent video shown by Concierge when someone selects Get paid back from my employer. Right now it shows a manual request and we want it to show a receipt being scanned.
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021850986914069355403
- Upwork Job ID: 1850986914069355403
- Last Price Increase: 2024-11-11
- Automatic offers:
- Krishna2323 | Contributor | 104920383
Issue Owner
Current Issue Owner: @abdulrahuman5196
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
For https://github.com/Expensify/Expensify/issues/432811 [Internal only design issue]
⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
Job added to Upwork: https://www.upwork.com/jobs/~021850986914069355403
Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Update the intent video for Get paid back from my employer
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
- We first need to upload the video to cloudfront.
- Then update the url below with the new video url. https://github.com/Expensify/App/blob/3540a3b3c05fa6a7c30633bbb9c3eaf3dbe1054e/src/CONST.ts#L89
What alternative solutions did you explore? (Optional)
Result
@anmurali, we need to upload the new video to https://d2k5nsl2zxldvw.cloudfront.net/ and then we can replace the url below with the new one. Or if we have already uploaded the video on Cloudfront then we need the url of the new video.
https://github.com/Expensify/App/blob/3540a3b3c05fa6a7c30633bbb9c3eaf3dbe1054e/src/CONST.ts#L89
@abdulrahuman5196, @nikihatesgh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
The video has been added here: https://github.com/Expensify/Web-Static/blob/main/videos/guided-setup-get-paid-back-v3.mp4
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
The url should be ${CLOUDFRONT_URL}/videos/guided-setup-get-paid-back-v3.mp4
Edit: currently broken, should be fixed tomorrow - will post an update when the fixed url is live.
@abdulrahuman5196, @nikihatesgh Whoops! This issue is 2 days overdue. Let's get this updated quick!
Proposal
Please re-state the problem that we are trying to solve in this issue.
Update the intent video for Get paid back from my employer
What is the root cause of that problem?
Change request
What changes do you think we should make in order to solve the problem?
Update the video url, duration, width, height base on the new video https://github.com/Expensify/App/blob/3540a3b3c05fa6a7c30633bbb9c3eaf3dbe1054e/src/CONST.ts#L88-L94
video: {
url: `${CLOUDFRONT_URL}/videos/guided-setup-get-paid-back-v3.mp4`,
thumbnailUrl: `${CLOUDFRONT_URL}/images/guided-setup-get-paid-back.jpg`,
duration: 26,
width: 1560,
height: 1280,
},
or set to any other width & height as needed but keep the video ratio
What alternative solutions did you explore? (Optional)
If we don't need the duration, width, and height declared there we can remove it, and only change the url
video: {
url: `${CLOUDFRONT_URL}/videos/guided-setup-get-paid-back-v3.mp4`,
thumbnailUrl: `${CLOUDFRONT_URL}/images/guided-setup-get-paid-back.jpg`,
},
And remove the duration, width, and height in other places as well
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@Krishna2323 's proposal here https://github.com/Expensify/App/issues/51603#issuecomment-2442515857 looks good and works well. Since this is a straightforward change, going with the first proposal.
🎀 👀 🎀 C+ Reviewed
Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
I thought we already had a PR in progress for this? I may have confused with something else though. Anyway, pretty straightforward change, let's get this done 🚀
📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.68-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/52677
If no regressions arise, payment will be issued on 2024-12-07. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @abdulrahuman5196 requires payment through NewDot Manual Requests
- @Krishna2323 requires payment automatic offer (Contributor)
Issue is ready for payment but no BZ is assigned. @RachCHopkins you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Payment Summary:
- Contributor: @Krishna2323 to be paid $125 via Upwork
- Contributor+: @abdulrahuman5196 to be paid $125 via NewDot Manual Request
Upwork job here
