App Hook up with the Downgrade Workspace API

Part of Add Workspace Plan Downgrades to NewDot

Steps to complete:

Create a new action
Connect it with the downgrade button

Issue Owner

Current Issue Owner: @carlosmiceli

Oct 26 '24 03:10 carlosmiceli

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Oct 26 '24 03:10 melvin-bot[bot]

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

Oct 26 '24 03:10 melvin-bot[bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

Oct 26 '24 03:10 melvin-bot[bot]

This will be the final issue to complete, so it needs to HOLD on all the other issues from the project. Will assign contributor then.

Oct 28 '24 15:10 carlosmiceli

I think we're still holding on this one, right?

Nov 11 '24 09:11 shawnborton

Will try to make progress today.

Nov 19 '24 15:11 carlosmiceli

We are close to being able to do this, final BE PR is in review and we can start testing FE and BE together.

Nov 28 '24 16:11 carlosmiceli

Hey @DylanDylann, this should be ready to tackle now that the BE is complete :)

Nov 30 '24 13:11 carlosmiceli

@DylanDylann this feature is ready for the FE part! Will you be able to handle this one?

Dec 09 '24 13:12 sonialiap

@carlosmiceli The API is up on my side. But I see a problem, Policy_DowngradeToTeam API returns lots of data and I see that there are two POLICYCHANGELOG_TEAM_DOWNGRADE report actions returned from BE

In my below video

Admin reportID: 8798864160178330

In this admin report, we have two POLICYCHANGELOG_TEAM_DOWNGRADE report actions with report action IDs: 1732067875874417562 and 2114614043739997111

https://github.com/user-attachments/assets/52c77fd3-43b0-43d3-b008-233152882fe5

Dec 12 '24 05:12 DylanDylann

@DylanDylann looking into it!

Dec 12 '24 19:12 carlosmiceli

@DylanDylann still haven't been able to figure out why we're seeing double report actions, but can we move forward with the PR and hardcode using the correct one while I discover what could be the issue and make the BE fix?

Dec 13 '24 05:12 carlosmiceli

@youssef-lr do you maybe have any suggestion about what could be happening here? I'm looking at the logs and I still haven't figured out yet where and why we are creating two report actions, but maybe you have a suggestions of where to look? Here is where we add the action at the moment.

Dec 13 '24 05:12 carlosmiceli

@carlosmiceli Yeah I already did the FE implementation locally with a branch built up from https://github.com/Expensify/App/pull/53343. I will raise PR after https://github.com/Expensify/App/pull/53343 is merged

Dec 13 '24 05:12 DylanDylann

Great!

Dec 13 '24 05:12 carlosmiceli

I'm OOO Dec 16-20, I don't think this will need a BZ before I'm back, but if it does please reapply the bug label

Dec 13 '24 12:12 sonialiap

@carlosmiceli, @shawnborton, @sonialiap, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

Dec 16 '24 09:12 melvin-bot[bot]

Not overdue, we're working on it :D

Dec 16 '24 23:12 carlosmiceli

@DylanDylann I think I found the issue with the duplicate action, but can we proceed using the first one while I try to fix it?

Dec 17 '24 16:12 carlosmiceli

Fixed, will be merged soon. The action that says this workspace instead of the policy name is the right one.

Dec 17 '24 18:12 carlosmiceli

Please ping me when the change is deployed

Dec 18 '24 04:12 DylanDylann

It's now deployed.

Dec 18 '24 23:12 carlosmiceli

@carlosmiceli Worked well

Dec 19 '24 04:12 DylanDylann

Fantastic, thanks sir! cc @garrettmknight

I'll go over all the open issues tomorrow to see what's left to do, but anything outstanding from your end @DylanDylann ?

Dec 19 '24 04:12 carlosmiceli

Everything works well from me

Dec 19 '24 04:12 DylanDylann

To confirm, this is still the plan, correct?

Dec 19 '24 05:12 carlosmiceli

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Dec 24 '24 08:12 melvin-bot[bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

Dec 26 '24 20:12 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.78-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/54356

If no regressions arise, payment will be issued on 2025-01-02. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@DylanDylann requires payment (Needs manual offer from BZ)

Dec 26 '24 20:12 melvin-bot[bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Dec 26 '24 20:12 melvin-bot[bot]