Expensify
[HOLD for payment 2024-12-03] [$250] Hybrid app - Loading skeleton when notification tapped and app is killed state
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1727449830031979
Action Performed:
- Have a long chat with User B
- As User A, access the chat on your device so it’s cached and kill the app
- As User B, message User A
- As User A, tap on the notification for the message.
Expected Result:
The full cached chat should be opened, potentially minus the most recent message.
Actual Result:
A skeleton page loads, indicating the app is reloading the chat from scratch rather than using the cache.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [x] Android: Native
- [ ] Android: mWeb Chrome
- [x] iOS: Native
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/bcce4fa4-e084-45d1-af36-f9510ae0c435
Profile_trace_for_9.0.41-2.cpuprofile
logs-2024-09-30 14_32_20.691.txt
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021844432440110156078
- Upwork Job ID: 1844432440110156078
- Last Price Increase: 2024-10-10
Issue Owner
Current Issue Owner: @eVoloshchak
Triggered auto assignment to @Beamanator (AutoAssignerNewDotQuality)
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
One possible fix to this (removing duplicate reconnectapp calls) is out, bumping to see if this is still happening here.
Triggered auto assignment to @stitesExpensify (AutoAssignerNewDotQuality)
@stitesExpensify reassigning since Alex is going to be OOO until Tuesday. Can you take a look? I'll try to grab logs from my repro in a minute.
I don't see any reason that this couldn't at least start as External to see if we can get it fixed by a contributor, so I'm going to start there and see where we end up!
Job added to Upwork: https://www.upwork.com/jobs/~021844432440110156078
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)
Actively discussing in the slack thread in the OP. Might be related to https://github.com/Expensify/App/pull/47243.
@garrettmknight @eVoloshchak @stitesExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@garrettmknight, @eVoloshchak, @stitesExpensify Huh... This is 4 days overdue. Who can take care of this?
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.52-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/51098
If no regressions arise, payment will be issued on 2024-10-30. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @eVoloshchak requires payment through NewDot Manual Requests
- @kirillzyusko does not require payment (Contractor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
- [ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
- [ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [ ] [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@kirillzyusko looks like @quinthar is still experiencing:
https://github.com/user-attachments/assets/b395a0c2-c922-4785-aec3-6e4e11cb32da
@garrettmknight @eVoloshchak @kirillzyusko @stitesExpensify this issue is now 4 weeks old, please consider:
- Finding a contributor to fix the bug
- Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
- If you have any questions, don't hesitate to start a discussion in #expensify-open-source
Thanks!
@garrettmknight, @eVoloshchak, @kirillzyusko, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Looks like a recent adhoc build is solving this! Let's keep it open till we've deployed and tested on prod, but I'll take over monitoring to keep an eye on the PR.
Hey @garrettmknight, I took a quick look, and I think we should update the description and reproduction steps and downgrade the current priority.
~~I'm unable to reproduce the loading skeleton issue for iOS or Android with the app either background or killed. @muttmuure mentioned this occurring for Concierge email chats, I didn't test that specific case but if that is still occurring I don't think it should be critical and take priority over our other HybridApp tasks.~~
^ I misunderstood the bug. Still don't think it's critical but we can get this looked at soon
https://github.com/user-attachments/assets/3c1a22a5-f71f-4fc1-8655-3644f4418811
https://github.com/user-attachments/assets/cf5a615d-b47a-46e7-9c4a-b26f55660d05
I found out that the problems are caused by this code: https://github.com/Expensify/App/blob/bd880d1e1a5ac0ef4bd7590c995b8569fe11f4ea/src/pages/home/ReportScreen.tsx#L349
In ND isLoadingApp is set to true before the bootsplash is hidden and messages are shown correctly. While in hybrid app it takes more time to finish loading the app and thus both isLoadingApp and isSidebarLoaded equal to false when ReportScreen is shown causing the skeleton to show up. I don't know why openApp (function that sets isAppLoading to false) takes more time on hybrid. I have to figure out what is causing this behaviour.
Sorry, yesterday I worked shorter hours and didn't had time to answer at the end of the day. I found out that on the ND when opening the app there is no OpenApp call. Instead ReconnectApp is called. So there are two options. The easier option is to enforce hybrid app to wait until OpenApp call is finished and only then hide bootsplash. The other way is to investigate why OpenApp is called every and check if it's necessary.
For now I'll to check the second option