App icon indicating copy to clipboard operation
App copied to clipboard

Upgrade `react-native` to 0.76

Open AndrewGable opened this issue 1 year ago • 11 comments

Problem

The new react-native version 0.76 just was released 🎉

https://github.com/facebook/react-native/releases/tag/v0.76.0-rc.0

It contains lots of bug fixes, improvements, and upgrades to the fundamental framework we are using.

Solution

Upgrade to react-native 0.76

cc @staszekscp @j-piasecki @WoLewicki - Per discussion in Slack, can you comment here so I can assign you to work on this? Thanks!

Issue OwnerCurrent Issue Owner: @j-piasecki

AndrewGable avatar Sep 10 '24 16:09 AndrewGable

Sure! We’ll take care of that!

staszekscp avatar Sep 10 '24 17:09 staszekscp

I'll be helping with the upgrade

j-piasecki avatar Sep 10 '24 17:09 j-piasecki

I've asked people from Expo and SDK 51 is not compatible with RN 0.76 (it won't compile due to underlying changes). Given that, I believe it may be best to wait for the first beta release of SDK 52 (targeted at the first half of October) before we start the upgrade process. This way we don't have to hack around making SDK 51 compile on the current React Native version, which would have to be discarded anyway. What do you think?

j-piasecki avatar Sep 17 '24 10:09 j-piasecki

This makes sense to me. cc @roryabraham @mountiny @luacmartins

AndrewGable avatar Sep 17 '24 16:09 AndrewGable

Same

mountiny avatar Sep 17 '24 20:09 mountiny

Agreed

luacmartins avatar Sep 17 '24 22:09 luacmartins

agreed

roryabraham avatar Sep 19 '24 18:09 roryabraham

Self-assigning as I am happy to help push this ahead in EU timezone

mountiny avatar Oct 07 '24 12:10 mountiny

In progress

mountiny avatar Nov 11 '24 13:11 mountiny

This issue has not been updated in over 15 days. @AndrewGable, @j-piasecki, @mountiny, @staszekscp eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Dec 09 '24 09:12 melvin-bot[bot]

Still in progress

mountiny avatar Dec 09 '24 11:12 mountiny

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] avatar Jan 08 '25 17:01 melvin-bot[bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] avatar Jan 09 '25 11:01 melvin-bot[bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Jan 10 '25 03:01 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.82-12 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/51475

If no regressions arise, payment will be issued on 2025-01-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @j-piasecki does not require payment (Contractor)
  • @staszekscp does not require payment (Contractor)

melvin-bot[bot] avatar Jan 10 '25 03:01 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.83-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/54961

If no regressions arise, payment will be issued on 2025-01-18. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @j-piasecki does not require payment (Contractor)
  • @staszekscp does not require payment (Contractor)

melvin-bot[bot] avatar Jan 11 '25 03:01 melvin-bot[bot]

We made it to production 🙌

mountiny avatar Jan 12 '25 18:01 mountiny

Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jan 12 '25 18:01 melvin-bot[bot]

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] avatar Jan 12 '25 18:01 melvin-bot[bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

melvin-bot[bot] avatar Jan 12 '25 18:01 melvin-bot[bot]

#I think we should pay @jayeshmangwani $500 for their review and testing, only issues came from hybrid that was tough to test at this point yet. In future update this limitation will be removed too

mountiny avatar Jan 12 '25 18:01 mountiny

So the only payment we need to issue here is to @jayeshmangwani for $500?

Let me know if i'm missing anyone 😃

OfstadC avatar Jan 16 '25 20:01 OfstadC

Yes I think that will be it! Thank you!

mountiny avatar Jan 17 '25 11:01 mountiny

Payment Summary

  • @jayeshmangwani due $500 via Manual New Expensify Request

OfstadC avatar Jan 17 '25 16:01 OfstadC

$500 approved for @jayeshmangwani

garrettmknight avatar Jan 21 '25 11:01 garrettmknight