App icon indicating copy to clipboard operation
App copied to clipboard
verified publisher icon Expensify

Add support for viewing group avatar photo

Open tsa321 opened this issue 1 year ago • 2 comments

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/39850 PROPOSAL: https://github.com/Expensify/App/issues/39850#issuecomment-2302580304

Tests

Here is the revised version with improved grammar:

Group Chat:

  1. Open a group report with a custom avatar.
  2. Click on the header to open the report details page.
  3. Click the avatar.
  4. Verify that the "View Photo" option is available, then click "View Photo."
  5. Ensure that the report avatar is displayed correctly.

Group Chat Thread:

  1. Go to any thread in the group chat.
  2. Click on the thread header to access the Details page.
  3. Click on the profile picture.
  4. Verify that the avatar opens in full screen.

Creating a New Group Chat:

  1. Click the "+" FAB button and select "Start New Chat."
  2. Choose two or more participants.
  3. On the New Chat confirmation page, click on the avatar and upload an image.
  4. Click on the avatar again.
  5. Verify that the "View Photo" option is available, then click "View Photo."
  6. Ensure that the avatar is displayed correctly.
  • [x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Group Chat:

  1. Open a group report with a custom avatar.
  2. Click on the header to open the report details page.
  3. Click the avatar.
  4. Verify that the "View Photo" option is available, then click "View Photo."
  5. Ensure that the report avatar is displayed correctly.

Group Chat Thread:

  1. Go to any thread in the group chat.
  2. Click on the thread header to access the Details page.
  3. Click on the profile picture.
  4. Verify that the avatar opens in full screen.

Creating a New Group Chat:

  1. Click the "+" FAB button and select "Start New Chat."
  2. Choose two or more participants.
  3. On the New Chat confirmation page, click on the avatar and upload an image.
  4. Click on the avatar again.
  5. Verify that the "View Photo" option is available, then click "View Photo."
  6. Ensure that the avatar is displayed correctly.
  • [x] Verify that no errors appear in the JS console

PR Author Checklist

  • [x] I linked the correct issue in the ### Fixed Issues section above
  • [x] I wrote clear testing steps that cover the changes made in this PR
    • [x] I added steps for local testing in the Tests section
    • [x] I added steps for the expected offline behavior in the Offline steps section
    • [x] I added steps for Staging and/or Production testing in the QA steps section
    • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • [x] I included screenshots or videos for tests on all platforms
  • [x] I ran the tests on all platforms & verified they passed on:
    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop
  • [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • [x] I followed proper code patterns (see Reviewing the code)
    • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • [x] I verified that comments were added to code that is not self explanatory
    • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [x] I followed the guidelines as stated in the Review Guidelines
  • [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • [x] I verified that if a function's arguments changed that all usages have also been updated correctly
  • [x] If any new file was added I verified that:
    • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [x] If a new CSS style is added I verified that:
    • [x] A similar style doesn't already exist
    • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [x] I verified that all the inputs inside a form are aligned with each other.
    • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/d26e8555-3c9a-4765-860e-13b7bc41ff2f

Android: mWeb Chrome

https://github.com/user-attachments/assets/bf1ab51b-e53d-4725-8eeb-5c8752b1f952

iOS: Native

https://github.com/user-attachments/assets/538179f2-be46-4430-bb90-065d0ce06658

iOS: mWeb Safari

https://github.com/user-attachments/assets/6fe6a036-f03c-45ac-8e2d-a2d37cc25739

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/cfd446f6-5e6c-48b8-af81-2bcfae673ef5

https://github.com/user-attachments/assets/34c5e821-c7cf-4653-88bf-59ba2424f0e6

MacOS: Desktop

https://github.com/user-attachments/assets/94749e85-f090-486b-a9ff-92ace36cd73d

tsa321 avatar Sep 07 '24 07:09 tsa321

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Sep 07 '24 07:09 melvin-bot[bot]

@s77rt There is a bug on Android where the avatar is not displayed when viewing a report avatar until the screen is tapped. This issue also occurs in the main when uploading a custom avatar to a workspace and then viewing the photo.

Bug:

https://github.com/user-attachments/assets/a0caa985-6ef0-437a-aae9-2413d0e71627

tsa321 avatar Sep 07 '24 07:09 tsa321

@tsa321 I have been testing this and I keep seeing bugs related to the group draft avatar which is increasing the work complexity without adding significant value to the UX. For now let's remove that functionality for the group draft (the NewChatConfirmPage) and only add implement it for actual reports.

s77rt avatar Sep 10 '24 13:09 s77rt

@s77rt PR is ready for review

tsa321 avatar Sep 11 '24 12:09 tsa321

@s77rt done

tsa321 avatar Sep 11 '24 23:09 tsa321

@s77rt done

tsa321 avatar Sep 16 '24 02:09 tsa321

Reviewer Checklist

  • [X] I have verified the author checklist is complete (all boxes are checked off).
  • [X] I verified the correct issue is linked in the ### Fixed Issues section above
  • [x] I verified testing steps are clear and they cover the changes made in this PR
    • [X] I verified the steps for local testing are in the Tests section
    • [X] I verified the steps for Staging and/or Production testing are in the QA steps section
    • [X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [X] I checked that screenshots or videos are included for tests on all platforms
  • [X] I included screenshots or videos for tests on all platforms
  • [X] I verified tests pass on all platforms & I tested again on:
    • [X] Android: Native
    • [X] Android: mWeb Chrome
    • [X] iOS: Native
    • [X] iOS: mWeb Safari
    • [X] MacOS: Chrome / Safari
    • [X] MacOS: Desktop
  • [X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • [X] I verified proper code patterns were followed (see Reviewing the code)
    • [X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • [X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • [X] I verified that comments were added to code that is not self explanatory
    • [X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [X] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [X] I verified that this PR follows the guidelines as stated in the Review Guidelines
  • [X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • [X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • [X] If a new component is created I verified that:
    • [X] A similar component doesn't exist in the codebase
    • [X] All props are defined accurately and each prop has a /** comment above it */
    • [X] The file is named correctly
    • [X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • [X] The only data being stored in the state is data necessary for rendering and nothing else
    • [X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • [X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • [X] All JSX used for rendering exists in the render method
    • [X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • [X] If any new file was added I verified that:
    • [X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [X] If a new CSS style is added I verified that:
    • [X] A similar style doesn't already exist
    • [X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • [X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [X] I verified that all the inputs inside a form are aligned with each other.
    • [X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native android
Android: mWeb Chrome mweb-chrome
iOS: Native ios
iOS: mWeb Safari mweb-safari
MacOS: Chrome / Safari web
MacOS: Desktop desktop

s77rt avatar Sep 16 '24 10:09 s77rt

@tsa321 Please remove the outdated testing steps

s77rt avatar Sep 16 '24 10:09 s77rt

@s77rt I have updated the test steps.

tsa321 avatar Sep 16 '24 12:09 tsa321

Thank you!

s77rt avatar Sep 16 '24 12:09 s77rt

@tsa321 conflicts here if you can fix them then we are ready to merge. Thanks!

marcaaron avatar Sep 16 '24 22:09 marcaaron

@marcaaron I have resolved the conflict. The check errors are from main.

tsa321 avatar Sep 16 '24 23:09 tsa321

I'd like to get a follow up going potentially to just review the necessary changes to fix the eslint warnings as they seem unrelated, potentially complex, and this one is ready to merge in it's current state.

There's more context on it here, but I am not sure if the refactoring effort needs to be combined into this PR. We might still ask you to do it. @roryabraham probably has more thoughts on this.

Edit: Gonna merge and left some reasoning here -> https://expensify.slack.com/archives/C01GTK53T8Q/p1726541893211989?thread_ts=1725905735.105989&cid=C01GTK53T8Q

marcaaron avatar Sep 17 '24 02:09 marcaaron

@marcaaron looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

melvin-bot[bot] avatar Sep 17 '24 03:09 melvin-bot[bot]

This was an eslint warning that we will fix in a follow up PR.

marcaaron avatar Sep 17 '24 03:09 marcaaron

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify avatar Sep 17 '24 03:09 OSBotify

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.37-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

OSBotify avatar Sep 17 '24 20:09 OSBotify

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

OSBotify avatar Sep 19 '24 23:09 OSBotify