App icon indicating copy to clipboard operation
App copied to clipboard

[$250] [Workspace feeds] update copy in card name step of issue card flow

Open kevinksullivan opened this issue 1 year ago • 12 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1725488109420779

Action Performed:

  1. Sign up with gmail account added to Workspace feeds beta
  2. Enable Expensify Card in more features
  3. Complete setup using credentials from option 3 in the SO
  4. Go through issue card flow, land on card name step

Expected Result:

Copy should say: Make it unique enough to tell apart from other cards. Specific use cases are even better!

  • Translation: Hazlo lo suficientemente único para distinguirla de otras tarjetas. ¡Los casos de uso específicos son aún mejores!

Actual Result:

Copy is currently wrong

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021832428586783897931
  • Upwork Job ID: 1832428586783897931
  • Last Price Increase: 2024-09-07
Issue OwnerCurrent Issue Owner: @

kevinksullivan avatar Sep 06 '24 17:09 kevinksullivan

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Sep 06 '24 17:09 melvin-bot[bot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Copy is currently wrong

What is the root cause of that problem?

Copy update

What changes do you think we should make in order to solve the problem?

Update this copy:

https://github.com/Expensify/App/blob/213d394ccf7e5658b1f21c5bfe2dbcaa9a9fe5df/src/languages/en.ts#L3191

https://github.com/Expensify/App/blob/213d394ccf7e5658b1f21c5bfe2dbcaa9a9fe5df/src/languages/es.ts#L3453

gijoe0295 avatar Sep 06 '24 18:09 gijoe0295

Sorry handling this with the team

mountiny avatar Sep 07 '24 14:09 mountiny

Job added to Upwork: https://www.upwork.com/jobs/~021832428586783897931

melvin-bot[bot] avatar Sep 07 '24 14:09 melvin-bot[bot]

Current assignees @allroundexperts and @ishpaul777 are eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Sep 07 '24 14:09 melvin-bot[bot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the issue card flow, the instructions for making a unique name is not clear.

What is the root cause of that problem?

Incorrect locales in both en and es files

What changes do you think we should make in order to solve the problem?

We need to update the giveItNameInstruction locale value with the updated text

What alternative solutions did you explore? (Optional)

abhinaybathina avatar Sep 07 '24 18:09 abhinaybathina

📣 @abhinaybathina! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot[bot] avatar Sep 07 '24 18:09 melvin-bot[bot]

Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~0168e425032efb76e6

abhinaybathina avatar Sep 07 '24 18:09 abhinaybathina

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

melvin-bot[bot] avatar Sep 07 '24 18:09 melvin-bot[bot]

Can you please assign this job to me?

abhinaybathina avatar Sep 07 '24 18:09 abhinaybathina

Hey @abhinaybathina, This issue is already assigned, there's many more issues that are open for proposal https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22

ishpaul777 avatar Sep 07 '24 18:09 ishpaul777

Okay, thanks! I'll check the others

abhinaybathina avatar Sep 07 '24 18:09 abhinaybathina

Deployed 2 weeks ago with this checklist https://github.com/Expensify/App/issues/48791#issuecomment-2342359302, should be ready for payment

ishpaul777 avatar Sep 23 '24 15:09 ishpaul777

Updated! We fixed two things in this PR so $250 is appropriate.

mountiny avatar Sep 23 '24 15:09 mountiny

Payment Summary

Upwork Job

  • Reviewer: @allroundexperts owed $250 via NewDot
  • ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@anmurali)

  • [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1832428586783897931/hired)
  • [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • [ ] I have verified the payment summary above is correct

melvin-bot[bot] avatar Sep 23 '24 18:09 melvin-bot[bot]

@anmurali, @allroundexperts, @mountiny, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Sep 26 '24 18:09 melvin-bot[bot]

Not overdue, Just waiting for payment

ishpaul777 avatar Sep 29 '24 16:09 ishpaul777

@anmurali, @allroundexperts, @mountiny, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Oct 02 '24 18:10 melvin-bot[bot]

@anmurali, @allroundexperts, @mountiny, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Oct 04 '24 18:10 melvin-bot[bot]

just pending payment, Melvin go away 💢

ishpaul777 avatar Oct 04 '24 18:10 ishpaul777

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Oct 05 '24 03:10 mvtglobally

Payment Summary

anmurali avatar Oct 05 '24 20:10 anmurali

Accpted, thanks!

ishpaul777 avatar Oct 08 '24 10:10 ishpaul777

$250 approved for @allroundexperts

JmillsExpensify avatar Oct 14 '24 21:10 JmillsExpensify