App icon indicating copy to clipboard operation
App copied to clipboard
verified publisher icon Expensify

[HOLD 45027][Search v2][Web-E] Deprecate old Search params

Open luacmartins opened this issue 1 year ago • 1 comments

Implement this section of the design doc.

Holding on:

  • [ ] https://github.com/Expensify/App/issues/45027

luacmartins avatar Jul 08 '24 23:07 luacmartins

Triggered auto assignment to @slafortune (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jul 08 '24 23:07 melvin-bot[bot]

Still on hold

luacmartins avatar Jul 23 '24 23:07 luacmartins

We're good to review the hold, yeah?

JmillsExpensify avatar Jul 30 '24 17:07 JmillsExpensify

Not yet, the holding PR is still in draft

luacmartins avatar Jul 30 '24 20:07 luacmartins

Just in case - adding another BZ - I'll be out until 8/21 and will check in on this then.

slafortune avatar Aug 13 '24 20:08 slafortune

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Aug 13 '24 20:08 melvin-bot[bot]

looks like the PR is in production - should we pay Rayane as C+ for the review? @luacmartins

Christinadobrzyn avatar Aug 20 '24 21:08 Christinadobrzyn

That PR is not related to this issue. I still haven't worked on this one.

luacmartins avatar Aug 20 '24 21:08 luacmartins

Since this is all internal, I'll unassign you from this issue.

luacmartins avatar Aug 20 '24 21:08 luacmartins

@luacmartins I reviewed the PR, which has now been in production for a week. However, I wasn't assigned to the issue or involved in the proposal review. Should I be assigned to this issue for compensation, or given the simple nature of the PR, can we close the issue and move on? Thank you.

brunovjk avatar Sep 03 '24 11:09 brunovjk

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Sep 03 '24 19:09 melvin-bot[bot]

@brunovjk I updated the issue to make sure we process payment for the PR review. Thanks for raising this!

luacmartins avatar Sep 03 '24 20:09 luacmartins

Thank you 🙏

brunovjk avatar Sep 03 '24 20:09 brunovjk

Sent an offer to @brunovjk - I'll check tomorrow to issue payment.

strepanier03 avatar Sep 03 '24 22:09 strepanier03

Payment summary

  • [x] $250 - @brunovjk via Upwork (offer)

strepanier03 avatar Sep 03 '24 22:09 strepanier03

Regression Test Proposal

  • Open the search page.
  • Select "Transactions."
  • Open your browser console.
  • Click on "Download."
  • Verify that the API request to ExportSearchToCSV includes jsonQuery in the payload.

Do we agree? 👍 or 👎

brunovjk avatar Sep 04 '24 10:09 brunovjk

No need to add the steps above, we're covering them as part of the project wrap up.

luacmartins avatar Sep 04 '24 16:09 luacmartins

Thanks @luacmartins, was just going to close the GH and saw you took care of that too, appreciate it!

strepanier03 avatar Sep 04 '24 17:09 strepanier03

All right, I've paid and closed the contract and this is ready to be closed as well. Thanks everyone!

strepanier03 avatar Sep 04 '24 17:09 strepanier03