App icon indicating copy to clipboard operation
App copied to clipboard

[$500] CRITICAL: [UX Reliability] Old messages show up as most recent, and the new messages didn't load for several minutes

Open muttmuure opened this issue 1 year ago • 24 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.82-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @kevinksullivan Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1717013309521369

Action Performed:

Break down in numbered steps

As part of OpenApp, we load a parent reportAction for all reports stored locally. When the app executes OpenReport, if present, we load the parent reportAction first.

  1. Alice texts message A to Bob in their DM
  2. Bob replies in a thread to the message A, which creates a new chat in their LHN
  3. Alice and Bob then continue to chat in their DM and end the conversation with the message B
  4. Bob signs out and then signs in again
  5. Bob now sees the DM and the thread of the message A in the LHN
  6. The DM has the preview of the message B in the LHN
  7. Bob opens the DM

Expected Result:

Bob should see the message B as the last message on the report page, or a loading spinner at the bottom, indicating that the report actions are fetched

Actual Result:

Bob sees the message A on the report page, with no loading spinner, until the OpenReport command returns the report actions.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019999ccc983033009
  • Upwork Job ID: 1803425149604648150
  • Last Price Increase: 2024-06-19
Issue OwnerCurrent Issue Owner: @fedirjh

muttmuure avatar Jun 13 '24 12:06 muttmuure

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Jun 13 '24 12:06 melvin-bot[bot]

Triggered auto assignment to @cristipaval (AutoAssignerNewDotQuality)

melvin-bot[bot] avatar Jun 13 '24 12:06 melvin-bot[bot]

From @mountiny -

We need to explore what is the consequence of not returning the parent report actions in the OpenApp for the app. It should solve this issue but I am not sure about its side effects

muttmuure avatar Jun 13 '24 12:06 muttmuure

Just started to look into this one. I'll first start with the Slack convo about the issue.

cristipaval avatar Jun 17 '24 11:06 cristipaval

Yes, I agree with @mountiny's suggested solution. I'll investigate if it is feasible not to return the parent report action in the parent report.

cristipaval avatar Jun 17 '24 12:06 cristipaval

Job added to Upwork: https://www.upwork.com/jobs/~019999ccc983033009

melvin-bot[bot] avatar Jun 19 '24 13:06 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

melvin-bot[bot] avatar Jun 19 '24 13:06 melvin-bot[bot]

Upwork job price has been updated to $500

melvin-bot[bot] avatar Jun 19 '24 13:06 melvin-bot[bot]

The bounty for the Critical issues is $500, correct?

cristipaval avatar Jun 19 '24 13:06 cristipaval

Yes, I agree with @mountiny's suggested solution. I'll investigate if it is feasible not to return the parent report action in the parent report.

Unfortunately, this doesn't seem feasible. I added the External label to get the contributors' help checking if we could update the existing logic around the loading spinner showing at the bottom of the chat when the App fetches report actions.

cristipaval avatar Jun 19 '24 13:06 cristipaval

Sounds good and thank you for looking at @cristipaval!

CortneyOfstad avatar Jun 19 '24 16:06 CortneyOfstad

FYI @CortneyOfstad, we're discussing more about this issue here

cristipaval avatar Jun 19 '24 16:06 cristipaval

Status: I'm trying to get some more engineering consensus here before I start implementing the changes in Auth.

cristipaval avatar Jun 20 '24 11:06 cristipaval

@CortneyOfstad, @cristipaval, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Jun 24 '24 18:06 melvin-bot[bot]

We got an engineering consensus on the internal solution. I'll start the implementation.

cristipaval avatar Jun 24 '24 18:06 cristipaval

@cristipaval any update on the implementation? Thanks!

CortneyOfstad avatar Jun 26 '24 19:06 CortneyOfstad

I started working on it. I'm trying to avoid making the already slow query even slower. I'm still looking to see if I can use the data already pulled from the DB here to build the reportAction data needed in Onyx.

cristipaval avatar Jun 27 '24 11:06 cristipaval

@CortneyOfstad @cristipaval this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Jun 27 '24 18:06 melvin-bot[bot]

Update: Draft Auth and Web-E PRs open.

cristipaval avatar Jun 27 '24 20:06 cristipaval

Draft PRs in review, we're discussing about them here

cristipaval avatar Jul 01 '24 12:07 cristipaval

The PRs are ready for review.

cristipaval avatar Jul 03 '24 00:07 cristipaval

Ok, so after more discussions, I'll have to spend some more time on the PRs to avoid making the OpenApp command get slower.

cristipaval avatar Jul 05 '24 11:07 cristipaval

@CortneyOfstad, @cristipaval Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Jul 08 '24 18:07 melvin-bot[bot]

We're still discussing the best solution.

cristipaval avatar Jul 08 '24 20:07 cristipaval

@CortneyOfstad, @cristipaval Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Jul 12 '24 18:07 melvin-bot[bot]

I am working on the PRs to make them pass Travis. Then I'll prepare the queries to time and make them ready for review.

cristipaval avatar Jul 12 '24 18:07 cristipaval

The Auth and Web-E PRs are under review.

cristipaval avatar Jul 15 '24 15:07 cristipaval

I need to rework the Auth PR a bit due to some real performance concerns

cristipaval avatar Jul 18 '24 16:07 cristipaval

Almost there, the Auth PR is in good shape and we might merge it soon

cristipaval avatar Jul 19 '24 21:07 cristipaval

I'm addressing some more feedback on the Auth PR. We might merge the Auth PR today.

cristipaval avatar Jul 22 '24 10:07 cristipaval