[$500] CRITICAL: [UX Reliability] Old messages show up as most recent, and the new messages didn't load for several minutes
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.82-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @kevinksullivan Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1717013309521369
Action Performed:
Break down in numbered steps
As part of OpenApp, we load a parent reportAction for all reports stored locally. When the app executes OpenReport, if present, we load the parent reportAction first.
- Alice texts
message Ato Bob in their DM - Bob replies in a thread to the
message A, which creates a new chat in their LHN - Alice and Bob then continue to chat in their DM and end the conversation with the
message B - Bob signs out and then signs in again
- Bob now sees the DM and the thread of the
message Ain the LHN - The DM has the preview of the
message Bin the LHN - Bob opens the DM
Expected Result:
Bob should see the message B as the last message on the report page, or a loading spinner at the bottom, indicating that the report actions are fetched
Actual Result:
Bob sees the message A on the report page, with no loading spinner, until the OpenReport command returns the report actions.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~019999ccc983033009
- Upwork Job ID: 1803425149604648150
- Last Price Increase: 2024-06-19
Issue Owner
Current Issue Owner: @fedirjh
Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @cristipaval (AutoAssignerNewDotQuality)
From @mountiny -
We need to explore what is the consequence of not returning the parent report actions in the OpenApp for the app. It should solve this issue but I am not sure about its side effects
Just started to look into this one. I'll first start with the Slack convo about the issue.
Yes, I agree with @mountiny's suggested solution. I'll investigate if it is feasible not to return the parent report action in the parent report.
Job added to Upwork: https://www.upwork.com/jobs/~019999ccc983033009
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)
Upwork job price has been updated to $500
The bounty for the Critical issues is $500, correct?
Yes, I agree with @mountiny's suggested solution. I'll investigate if it is feasible not to return the parent report action in the parent report.
Unfortunately, this doesn't seem feasible. I added the External label to get the contributors' help checking if we could update the existing logic around the loading spinner showing at the bottom of the chat when the App fetches report actions.
Sounds good and thank you for looking at @cristipaval!
FYI @CortneyOfstad, we're discussing more about this issue here
Status: I'm trying to get some more engineering consensus here before I start implementing the changes in Auth.
@CortneyOfstad, @cristipaval, @fedirjh Huh... This is 4 days overdue. Who can take care of this?
We got an engineering consensus on the internal solution. I'll start the implementation.
@cristipaval any update on the implementation? Thanks!
I started working on it. I'm trying to avoid making the already slow query even slower. I'm still looking to see if I can use the data already pulled from the DB here to build the reportAction data needed in Onyx.
@CortneyOfstad @cristipaval this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Draft PRs in review, we're discussing about them here
The PRs are ready for review.
Ok, so after more discussions, I'll have to spend some more time on the PRs to avoid making the OpenApp command get slower.
@CortneyOfstad, @cristipaval Whoops! This issue is 2 days overdue. Let's get this updated quick!
We're still discussing the best solution.
@CortneyOfstad, @cristipaval Whoops! This issue is 2 days overdue. Let's get this updated quick!
I am working on the PRs to make them pass Travis. Then I'll prepare the queries to time and make them ready for review.
The Auth and Web-E PRs are under review.
I need to rework the Auth PR a bit due to some real performance concerns
Almost there, the Auth PR is in good shape and we might merge it soon
I'm addressing some more feedback on the Auth PR. We might merge the Auth PR today.