App icon indicating copy to clipboard operation
App copied to clipboard

HIGH: [Live Markdown] [$500] Android - Chat - User unable to select complete sentence

Open kbecciv opened this issue 1 year ago • 16 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.65.0 Reproducible in staging?: y Reproducible in production?: n Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap on a report
  3. Enter a sentence
  4. Try to select complete sentence

Expected Result:

User must be able to select complete sentence

Actual Result:

User unable to select complete sentence

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [x] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/29ff8a2e-c60a-4853-95fc-23a1fc8c440c

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017bd806a6be2ddbfd
  • Upwork Job ID: 1783137020323028992
  • Last Price Increase: 2024-04-24
  • Automatic offers:
    • abdulrahuman5196 | Reviewer | 0

kbecciv avatar Apr 24 '24 13:04 kbecciv

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Apr 24 '24 13:04 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Apr 24 '24 13:04 github-actions[bot]

We think that this bug might be related to #vip-vsb

kbecciv avatar Apr 24 '24 13:04 kbecciv

Job added to Upwork: https://www.upwork.com/jobs/~017bd806a6be2ddbfd

melvin-bot[bot] avatar Apr 24 '24 14:04 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

melvin-bot[bot] avatar Apr 24 '24 14:04 melvin-bot[bot]

I do not have android device to reproduce this unfortuntely

mountiny avatar Apr 24 '24 16:04 mountiny

Issue is still reproducible on build 1.4.65.3

https://github.com/Expensify/App/assets/93399543/434ed363-c4b0-4634-8cb5-90a8942a9308

kbecciv avatar Apr 24 '24 17:04 kbecciv

Upwork job price has been updated to $500

melvin-bot[bot] avatar Apr 24 '24 17:04 melvin-bot[bot]

I want to solve this issue but I am unable to run the project on my mac , because of I don't have MapBox token

KirtirajM avatar Apr 25 '24 12:04 KirtirajM

📣 @KirtirajM! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot[bot] avatar Apr 25 '24 12:04 melvin-bot[bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

melvin-bot[bot] avatar Apr 25 '24 12:04 melvin-bot[bot]

Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~017ac6dbe6c552ee4c

kirtiraj-malkhede-au6 avatar Apr 25 '24 12:04 kirtiraj-malkhede-au6

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

melvin-bot[bot] avatar Apr 25 '24 12:04 melvin-bot[bot]

@Skalakid is going to investigate this one

I am going to demote the blocker label as there is no clear offending PR for this one and it looks like it might be device specific issue too. There is a workaround for the user to use the long press and copy to clipboard

mountiny avatar Apr 25 '24 13:04 mountiny

Hi, I'm Michał from Software-Mansion and I will investigate this issue

Skalakid avatar Apr 25 '24 13:04 Skalakid

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] avatar Apr 25 '24 13:04 melvin-bot[bot]

After investigation, I found that the problem with text selection on Android had a root cause in the react-native-live-markdown library. It was only reproducible after enabling the new architecture. I reported this bug and asked for help from our SWM team that worked on that. @j-piasecki came up with the fix in the library - PR and @WoLewicki prepared the PR that bumps the live markdown version in E/App

Skalakid avatar Apr 29 '24 07:04 Skalakid

is the work being done in this PR going to fix this issue?

hayata-suenaga avatar Apr 30 '24 19:04 hayata-suenaga

@mountiny, @Skalakid, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar May 02 '24 18:05 melvin-bot[bot]

@hayata-suenaga The issue has been fixed inside the react-native-live-markdown library and this PR contained version bump inside it. However, I can see that the library version has been already updated on main, so the issue should be fixed for now

Skalakid avatar May 06 '24 09:05 Skalakid

@mountiny, it seems like we can close this issue 😄

hayata-suenaga avatar May 06 '24 21:05 hayata-suenaga

@kavimuru @isagoico Could you please retest this issue on latest Android version?

mountiny avatar May 08 '24 19:05 mountiny

@kavimuru @isagoico - Can you give an ETA on retesting on Android?

quinthar avatar May 09 '24 23:05 quinthar

Apologies that we missed this yesterday. Checking with the team as I don't have my Android charged up and will post the results shortly.

isagoico avatar May 09 '24 23:05 isagoico

Tester was unable to reproduce this on the latest version 1.4.72-1

https://github.com/Expensify/App/assets/44479856/ea5f764e-1ed9-4772-9859-a14283c84b53

isagoico avatar May 09 '24 23:05 isagoico

Thank you, i will close then!

mountiny avatar May 10 '24 14:05 mountiny