App icon indicating copy to clipboard operation
App copied to clipboard

Ensure that Group Chat "invited" and "removed" system messages show correctly in the LHN

Open marcaaron opened this issue 1 year ago • 2 comments

Problem

Coming from @s77rt's comment here. These messages look strange in the LHN.

Solution

Workspace rooms do not have this problem. So presumably there is some issue in the backend we need to fix, but it might be a frontend issue as well. Actually, @jasperhuangg probably knows why and can answer this question faster than us.

marcaaron avatar Apr 12 '24 21:04 marcaaron

@marcaaron this is expected. We don't show the email address of users since for some reports, we don't know whether or not the users are allowed to view them (like in public rooms)

We could distinguish between the public/non public rooms, but this isn't something that needs to be addressed now.

jasperhuangg avatar Apr 12 '24 21:04 jasperhuangg

If you look at the link the LHN messages are broken so I think we need to apply the same change we did for rooms to group chats or something. This is what they look like for Group Chats:

321556576-d4d2d8dd-8fc8-478d-ad69-e281f37bfe1e

So, feels like we missed a detail somewhere - but I haven't looked into where yet.

marcaaron avatar Apr 13 '24 00:04 marcaaron

Looking at this one today.

marcaaron avatar Apr 30 '24 00:04 marcaaron

Waiting for deploy.

marcaaron avatar May 01 '24 20:05 marcaaron

@marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar May 09 '24 18:05 melvin-bot[bot]

@marcaaron Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar May 13 '24 19:05 melvin-bot[bot]

@marcaaron 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] avatar May 15 '24 20:05 melvin-bot[bot]

This is done now.

marcaaron avatar May 15 '24 20:05 marcaaron