HIGH: [Comment linking] Update thread headers / ancestry to deep link back to the original comment

[quinthar]

Problem:

When you click into a thread, the header says:

• First line: (the comment that is being threaded)
• Second line: From (the room containing the comment being threaded)

When you click the second line, it does open the parent room. However, it scrolls to the bottom of that room, losing context.

Solution:

Now that we have comment linking, when you click the second line, deep link directly to the comment that this thread is under.

[quinthar]

@perunt - Can you take this one?

[quinthar]

Actually, nevermind, dupe of this: https://github.com/Expensify/App/pull/38722#issuecomment-2019552569

[quinthar]

Reverted, reopening

[rayane-d]

👍

[quinthar]

@rayane-djouah What is your ETA for fixing this?

[rayane-d]

@quinthar, I'll be addressing it this week. I anticipate completing it by the end of the week. Shall we consider adding a bounty to this issue? This request entails extra work that wasn't initially scoped in the original issue, and it's worth noting that comment linking is a beta feature.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~013ec77e7b4b484ddd

[melvin-bot[bot]]

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

[quinthar]

how about $250 for the bounty?

[melvin-bot[bot]]

Upwork job price has been updated to $250

[rayane-d]

Sounds good to me. Thank you!

[rayane-d]

PR in progress

[rayane-d]

All previous blockers are now fixed:

• [x] https://github.com/Expensify/App/issues/39251 Fixed
• [x] https://github.com/Expensify/App/issues/39264 Fixed
• [x] https://github.com/Expensify/App/issues/39242 Fixed
• [x] https://github.com/Expensify/App/issues/39291 Fixed
• [x] https://github.com/Expensify/App/issues/39277 Fixed

[rayane-d]

PR ready for review - cc @rushatgabhane

[melvin-bot[bot]]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

@rayane-djouah looks like we have an edge case https://github.com/Expensify/App/issues/40027

could you please handle it? thanks!

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[rayane-d]

@rayane-djouah looks like we have an edge case #40027

could you please handle it? thanks!

Can do.

Edit: PR: https://github.com/Expensify/App/pull/40155

[quinthar]

What's the ETA in this? Is anything blocking it? Can we get this done today?

[rayane-d]

This is now on staging

[quinthar]

Great!!

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.62-17 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/39454

If no regressions arise, payment will be issued on 2024-04-25. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

Issue is ready for payment but no BZ is assigned. @puneetlath you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot[bot]]

Payment Summary

Upwork Job

• ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1775298204363497472/hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[puneetlath]

Looks like @rayane-djouah implemented this and @rushatgabhane was the C+ is that right?

[rayane-d]

Looks like @rayane-djouah implemented this and @rushatgabhane was the C+ is that right?

@puneetlath, Correct!

[melvin-bot[bot]]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[puneetlath]

Payment Summary:

• C - $250 - @rayane-djouah - to be paid via Upwork
• C+ - $250 - @rushatgabhane - to be paid via NewDot

@rayane-djouah did you get an offer from the automation above?