Fix created distance request briefly shows the user local currency instead of the workspace currency

[bernhardoj]

Details

When creating a distance request, the currency is taken from the workspace currency, but a bug makes it using the user local currency unintentionally and this PR fix that.

Fixed Issues

$ https://github.com/Expensify/App/issues/37643 PROPOSAL: https://github.com/Expensify/App/issues/37643#issuecomment-1974732849

Tests

Same as QA Steps

• [x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have a workspace with a currency set to different currency than your local currency

1. Open the workspace chat
2. Create a new distance request
3. Verify the distance request preview shows the workspace currency

Another test step from https://github.com/Expensify/App/issues/33608:

1. Tap FAB button
2. Tap Request money
3. Select Manual tab
4. Select a currency and enter any amount
5. Tap Next
6. Select a participant
7. In confirmation page, click on Amount field to edit
8. Click on Currency and change to another one
9. Again click on Currency and verify the new selected currency is shown

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/f304dc5d-f542-40af-b67a-6ccb9b9d0a2d

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/45eb6bc6-4df6-4219-96ce-8be710ad439f

iOS: Native

https://github.com/Expensify/App/assets/50919443/363b6c74-13b7-43e7-9d37-034c0ab66ce4

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/73611e3f-51b8-40b0-b137-9c1ab2aeedf0

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/e3310349-7c1d-4935-acff-4c898f47122a

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/11d625f2-bd4b-4a20-9ced-33404080a36a

[melvin-bot[bot]]

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[bernhardoj]

Additional video showing:

1. https://github.com/Expensify/App/issues/33608 is still fixed

https://github.com/Expensify/App/assets/50919443/dc2e4ef1-dc13-4d4e-8c1d-a22d9552f89e

2. If the currency param is invalid, we use the transaction currency

https://github.com/Expensify/App/assets/50919443/06739d16-e638-4d6a-a1bc-1944aa89e6d3

[sobitneupane]

@bernhardoj Can you please merge main, Reassure Performance Tests is failing and doesn't look related to this PR.

[sobitneupane]

@bernhardoj Let's include the test steps for https://github.com/Expensify/App/issues/33608 issue as well.

[bernhardoj]

Merged with main. Now we have TS error.

Let's include the test steps for https://github.com/Expensify/App/issues/33608 issue as well.

Added. The video is on my prev comment (I only added web because it's not a platform specific code)

[sobitneupane]

@bernhardoj TypeScript Checks is definitely not related to this PR. But Performance Tests is also failing again. Is it related to change in this PR? If not, let's wait for the issue to be fixed in the main branch before proceeding.

[bernhardoj]

Most likely not related.

It fails on sign-in page test.

The test success locally, might be a flaky test. We can re-run it until it success.

[bernhardoj]

The reassure test fails on my other PR too here, merging with main again to re-run it.

[jeremy-croff]

@bernhardoj Removing the loading indicator in this PR re-introduces bug from https://github.com/Expensify/App/issues/35147#event-12178382581

[bernhardoj]

Oh, I don't know the loading indicator unintentionally fixed another issue. But since we remove the originalCurrency property from the transaction object, I don't think there is a way to know whether an Onyx merging completes or not.

Here is the issue:

https://github.com/Expensify/App/assets/50919443/fde6a4cf-45f5-41f4-bc16-5300c8908825

Do we really need to do something with it? I would say no because it's a common Onyx "issue" and happens on other places too, for example:

https://github.com/Expensify/App/assets/50919443/3ef9592a-4355-44e1-bd90-b3fcd34f8cd6

https://github.com/Expensify/App/assets/50919443/fe906dd8-905b-4bda-be9e-cb28e671afeb

[bernhardoj]

Just fixed a conflict, let's get this finished before more conflict comes up.

[sobitneupane]

@roryabraham I think we can get his merged.

[roryabraham]

hey, really sorry for the delay here - I fell behind on some of my reviews. Let's resolve conflicts here and get this over the finish line

[bernhardoj]

@roryabraham conflicts solved.

[roryabraham]

more conflicts, again

[bernhardoj]

@roryabraham conflicts solved

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅