[No QA] Replace usages of useWindowDimensions with useResponsiveLayout in components folder

[rayane-d]

cc @getusha

Details

https://github.com/Expensify/App/issues/30528#issuecomment-1868485991

Fixed Issues

$ PROPOSAL:

Tests

Perform general regression testing verifying that app layouts and styles are correct.

• [x] Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No QA

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/77965000/6b564907-ca2c-41d5-b5a1-220cd71c0ac1

Android: mWeb Chrome

https://github.com/Expensify/App/assets/77965000/c59f7004-b6f9-48ca-aeec-1fa989bb21f2

iOS: Native

https://github.com/Expensify/App/assets/77965000/918067cc-856b-447c-aacd-69cc32a6fe57

iOS: mWeb Safari

https://github.com/Expensify/App/assets/77965000/684b2af2-10d7-4964-8658-695d0abb7cf9

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/77965000/0a7f5b44-dc07-49d3-863c-c5cc715bf0df

MacOS: Desktop

https://github.com/Expensify/App/assets/77965000/296ef5de-e7a4-4105-ac20-413f328bf4cb

[melvin-bot[bot]]

@monilbhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[rayane-d]

@MonilBhavsar you can unassign yourself. this part of https://github.com/Expensify/App/issues/30528, @getusha will review

[getusha]

@rayane-djouah looks like we have a merge conflict.

[getusha]

@rayane-djouah I think we need to add QA steps or mark it as No QA?

[getusha]

@rayane-djouah check my comments please.

[rayane-d]

sorry for the delay @getusha I updated the PR

[rayane-d]

@rayane-djouah I think we need to add QA steps or mark it as No QA?

I think that we should ask QA team to do regression testing with an Ad-hoc build before we merge, what do you think?

[rayane-d]

I think that we should ask QA team to do regression testing with an Ad-hoc build before we merge, what do you think?

what do you think @roryabraham about ^

[roryabraham]

Hmmm I think that sounds like it might be overkill in this case, but I'll make an AdHoc build

[rayane-d]

it didn't work @roryabraham

[roryabraham]

ah, sorry I think I was on mobile and couldn't kick it off. Doing that now...

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/36292/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/36292/index.html
Desktop :computer:	Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/36292/NewExpensify.dmg	https://36292.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[getusha]

Thanks @roryabraham, testing.

[getusha]

BUG: wrong animation when closing avatar modal

1. Open profile page
2. Press on the avatar
3. Close it.

We can notice it changes to small screen layout quickly

https://github.com/Expensify/App/assets/75031127/a84dfa0f-6dc8-4afc-bd7b-c68a7ddafcc2

[getusha]

BUG: Emoji picker strangely expanding from status page

1. Account settings > Profile > Status
2. Open the emoji picker from the dropdown

https://github.com/Expensify/App/assets/75031127/86f21444-e59e-4a8b-b4a3-185bdaf8e538

[getusha]

BUG: Wrong layout on the state picker page

1. Go to Account settings > Profile
2. Press on Address
3. State

https://github.com/Expensify/App/assets/75031127/42e11c15-fb66-4e14-b627-c91b9f2adc6f

[getusha]

Related? refreshing leads to not found page.

https://github.com/Expensify/App/assets/75031127/2e4a25ef-4bfd-4d1b-a8b0-818cd57c6137

[getusha]

@rayane-djouah Friendly bump

[rayane-d]

Related? refreshing leads to not found page.

I think that this is not related

[rayane-d]

Updated

[rayane-d]

friendly bump @getusha

[getusha]

Reviewer Checklist

• [x] I have verified the author checklist is complete (all boxes are checked off).
• [x] I verified the correct issue is linked in the ### Fixed Issues section above
• [x] I verified testing steps are clear and they cover the changes made in this PR
  • [x] I verified the steps for local testing are in the Tests section
  • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
  • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• [x] I checked that screenshots or videos are included for tests on all platforms
• [x] I included screenshots or videos for tests on all platforms
• [x] I verified tests pass on all platforms & I tested again on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• [x] I verified proper code patterns were followed (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
• [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] If a new component is created I verified that:
  • [x] A similar component doesn't exist in the codebase
  • [x] All props are defined accurately and each prop has a /** comment above it */
  • [x] The file is named correctly
  • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [x] The only data being stored in the state is data necessary for rendering and nothing else
  • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [x] All JSX used for rendering exists in the render method
  • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/75031127/07d69ebf-ec36-476d-9967-92a823cd3db0

Android: mWeb Chrome

https://github.com/Expensify/App/assets/75031127/d5d1c530-378e-4fef-a26d-cc81d556fec1

iOS: Native

https://github.com/Expensify/App/assets/75031127/7af953b1-1c99-4869-8a8a-0c75399f953e

iOS: mWeb Safari

https://github.com/Expensify/App/assets/75031127/d1e82321-1aef-48b0-ae0c-9e3ac227d90b

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/75031127/17c3108c-2c36-468b-87a5-1e83a1a9dd69

https://github.com/Expensify/App/assets/75031127/f4b07a16-5eaa-46a3-a0d9-74404c8189af

MacOS: Desktop

https://github.com/Expensify/App/assets/75031127/3e183dd9-35b0-48b2-830f-a93e3659653d

[getusha]

@rayane-djouah there are several places we shouldn't be showing the offline indicator

example:

[rayane-d]

Updated

[getusha]

@rayane-djouah one more issue

Go to Workspace Settings > Bank Account > Start over

You can also notice a flickering of the size on the update to USD modal

https://github.com/Expensify/App/assets/75031127/c6e4082c-6bcb-4ee7-b819-2031625aceb9

[getusha]

I think we should avoid using shouldUseNarrowLayout in Modal components.

[roryabraham]

I think we should avoid using shouldUseNarrowLayout in Modal components

I'm confused by this ... isn't this one of the primary use-cases where we'd want to use a narrow layout even if we have a wide screen?

[getusha]

I'm confused by this ... isn't this one of the primary use-cases where we'd want to use a narrow layout even if we have a wide screen?

@roryabraham When a modal appears, for example while the RHP is open, it will display a layout intended for narrower screens even on larger screens. check this https://github.com/Expensify/App/pull/36292#issuecomment-1985925977

[roryabraham]

I think we should avoid using shouldUseNarrowLayout in Modal components

Got it, I agree for popovers and "alert-style" modals 👍🏼

[getusha]

@rayane-djouah can you pull main and make sure every component is updated & this? thanks!