[$500] iOS - Saved Private note field not sticky, page can be scrolled

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.36 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): [email protected] Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

1. Launch New Expensify app
2. Open either #announce room, #admins room or 1:1 conversation
3. Tap on header to go to details or profile page
4. Tap on Private notes option
5. Enter note & save it
6. Scroll the private notes page (Note: Saved note field not sticky)

Expected Result:

Saved note field should be sticky & should not be able to scroll

Actual Result:

Saved note field should be sticky & should not be able to scroll

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/cf935a7e-b28b-4b33-aa27-6f67be8fef84

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015ac87fcf9eab0d9e
• Upwork Job ID: 1754195036051189760
• Last Price Increase: 2024-02-04
• Automatic offers:
• situchan | Contributor | 28149495

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~015ac87fcf9eab0d9e

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot[bot]]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp CC @quinthar

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Saved Private note field not sticky, page can be scrolled

What is the root cause of that problem?

We have made the notes to be scrollable.

https://github.com/Expensify/App/blob/3ab4e6e12d9ff38e69493321f0d31f032481b373/src/pages/PrivateNotes/PrivateNotesListPage.tsx#L92

What changes do you think we should make in order to solve the problem?

Make them sticky and not scrollable

<ScrollView 
  contentContainerStyle={styles.flexGrow1}
  stickyHeaderIndices={privateNotes.map((_, index) => index)}
>
  {privateNotes.map((item) => getMenuItem(item))}
</ScrollView>

What alternative solutions did you explore? (Optional)

N/A

[jeremy-croff]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The private notes are scrollable when there's no need to be scrollable.

What is the root cause of that problem?

We use a ScrollView component

What changes do you think we should make in order to solve the problem?

Use a regular View component Will be scrollable once the content overflows.

component to replace is here: https://github.com/Expensify/App/blob/3ab4e6e12d9ff38e69493321f0d31f032481b373/src/pages/PrivateNotes/PrivateNotesListPage.tsx#L92

What alternative solutions did you explore? (Optional)

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Saved Private note field not sticky, page can be scrolled

What is the root cause of that problem?

This is default bouncing behavior on iOS

What changes do you think we should make in order to solve the problem?

https://github.com/Expensify/App/blob/3ab4e6e12d9ff38e69493321f0d31f032481b373/src/pages/PrivateNotes/PrivateNotesListPage.tsx#L92 To be consistent with other platforms, we can disable bounce so pass bounces={false} to ScrollView

What alternative solutions did you explore? (Optional)

We can just close this as not bug

[Christinadobrzyn]

I think this can be external, low priority, and seems to only be affecting iOS.

@Santhosh-Sellavel feel free to review the proposals.

[Santhosh-Sellavel]

Unassigning this one due to low bandwidth, please reassign @Christinadobrzyn!

[situchan]

I can review this

[Santhosh-Sellavel]

@situchan Are you subscribed to me? 😅

[situchan]

@situchan Are you subscribed to me? 😅

Not only you 😄. I am subscribed to most issues/PRs to get full understanding of project status

[melvin-bot[bot]]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[Christinadobrzyn]

I think we're reviewing proposals right @situchan?

[situchan]

@Christinadobrzyn to confirm, do you agree with expected behavior: Saved note field should be sticky & should not be able to scroll? This is iOS feature but should be fixed as inconsistent with other platforms?

[Christinadobrzyn]

Hi @situchan

Saved note field should be sticky & should not be able to scroll

Yes, I agree this should be the expected behaviour

This is iOS feature but should be fixed as inconsistent with other platforms?

Yes, I agree, it looks like this behaviour is exclusive to iOS and isn't happening on our other platforms. So I think this needs to be fixed to be consistent with the behaviour on our other apps. iOS Private Notes should behave the same as on other platforms.

Let me know if that helps!

[situchan]

@Christinadobrzyn thanks. In that case, @mkhutornyi's proposal looks good to me. 🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[mkhutornyi]

PR will be ready by end of week

[melvin-bot[bot]]

@Beamanator @Christinadobrzyn @mkhutornyi @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Christinadobrzyn]

PR is in staging - https://github.com/Expensify/App/pull/36772

[situchan]

PR was deployed to production on Feb 28

[Christinadobrzyn]

Payouts due:

Contributor: $500 @mkhutornyi (paid in Upwork) Contributor+: $500 @situchan (paid in Upwork)

Upwork job is here.

Do we need a regression test for this @situchan?

[situchan]

No need regression test as reported by QA team and issue is minor enough

[Christinadobrzyn]

Awesome - thanks for conifrming @situchan! Closing this!