Expensify
[$500] BA - Error message for wrong account number does not appear, unexpected error instead
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.34-1 Reproducible in staging?: Y Reproducible in production?: Not able to test on production If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4255853 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Pre-requisite: user must be logged in and have created a Workspace
- Go to Settings > Workspaces > Select Workspace > Bank account
- Select "Connect online with Plaid"
- Go trough the add bank account process, select Chase and the account ending with 1111
- Enter the Routing number
- On the account number field, enter "1111222233334444"
- Click on "Continue"
Expected Result:
An error message should be displayed: "Your account number should end with 1111"
Actual Result:
Another error message is displayed: "An unexpected error occurred while trying to add your bank account. Please try again": An unexpected error occurred while trying to add your bank account. Please try again.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/8cc09348-50bc-4e97-81d2-2c2b8c7c77aa
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01665cdc2655d7f614
- Upwork Job ID: 1752870011138125824
- Last Price Increase: 2024-02-01
Job added to Upwork: https://www.upwork.com/jobs/~01665cdc2655d7f614
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)
Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
An error message should be displayed: "Your account number should end with 1111"
confirming: This is the expected behavior? Why would this error say that? 🤔
Ok error looks like it would be thrown from here. I see @Gonals and @MariaHCD in some git blames (quite old though) so maybe they have some context or an idea about what to look at next.
On first glance, I don't see any changes in the current staging App checklist that might cause this.
Ok error looks like it would be thrown from here. I see @Gonals and @MariaHCD in some git blames (quite old though) so maybe they have some context or an idea about what to look at next.
On first glance, I don't see any changes in the current staging App checklist that might cause this.
Heh. That was a while ago 😅. I don't really recall much of it off the top of my head, but I agree this doesn't seem like a blocker
I am curious why we have to manually enter the routing number and account number when we already fetched those via Plaid and then got the selection from the user.
I agree, it doesn't have to be a deploy blocker.
If we decide this is not a deploy blocker, I think we can close this/ put on hold for the bank account flow refactor which will update lots of the patterns here #34498
@marcaaron @nkuoch Actually I think Nathalie fixed it with https://github.com/Expensify/Web-Expensify/pull/40755/files
Weird, can't reproduce in dev nor staging
@lanitochka17 What email did you use, so I can check the logs?
@nkuoch, @johncschuster, @parasharrajat, @marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick!
@lanitochka17 Didn't find anything obvious from the logs, and still cannot reproduce it. @lanitochka17 Are you sure you can reproduce it?
I can't: https://github.com/Expensify/App/assets/2463975/33db890a-3c15-4168-810d-f22dc88cb074
Closing, please reopen if you can reproduce it.