App icon indicating copy to clipboard operation
App copied to clipboard

[$1000] Attachments - Unable to upload attachments in certain rooms

Open isagoico opened this issue 2 years ago • 23 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.30-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @rafecolton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705433392285439

Action Performed:

  1. Log in with a Expensifail account
  2. Navigate to the room #applause.expensifail.com (https://staging.new.expensify.com/r/5324367938904284)
  3. Send an image to the chat
  4. Login to another Expensifail account
  5. Navigate to the room #applause.expensifail.com (https://staging.new.expensify.com/r/5324367938904284
  6. Verify if you can see the uploaded image

Expected Result:

Image is uploaded and displayed in the conversation history.

Actual Result:

The image uploads for a while then an error is displayed in chat and in JS console

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop

Screenshots/Videos

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015a3eadd41d507135
  • Upwork Job ID: 1749905365297426432
  • Last Price Increase: 2024-02-06

isagoico avatar Jan 23 '24 21:01 isagoico

Job added to Upwork: https://www.upwork.com/jobs/~015a3eadd41d507135

melvin-bot[bot] avatar Jan 23 '24 21:01 melvin-bot[bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Jan 23 '24 21:01 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

melvin-bot[bot] avatar Jan 23 '24 21:01 melvin-bot[bot]

This might be related to https://github.com/Expensify/App/issues/35017 Since comes first in the process (you have to upload before seeing multiple images, I'm going to put the other on hold pending this one).

mallenexpensify avatar Jan 23 '24 23:01 mallenexpensify

I'm experiencing this, but the attachment does seem to actually upload: other people are reacting to it, at least

image image

I've updated OP for repro steps to check if others can see it.

peterdbarkerUK avatar Jan 24 '24 10:01 peterdbarkerUK

@NicMendonca need a Expensifail account to test this C+/contributors don't have one so can you make this internal please, thanks!

Santhosh-Sellavel avatar Jan 24 '24 19:01 Santhosh-Sellavel

Happened to me last night then tested again this morn to reproduce

  • Open #social room
  • Type some text
  • Drag drop an image file to the compose box
  • Click button to upload
  • Leave chat at #social for a while, hoping that it uploads (never left #social for this test)
  • Observe receiving error and that image didn't upload image

What I see in the console image

image

@NicMendonca can you try to reproduce in #social? If you can't, will you please swap me out with you as assignees? Thx

mallenexpensify avatar Jan 25 '24 18:01 mallenexpensify

Both the pic and the text posted, although they still shows as not on my end. image

image

What's weird is that, on mobile, it's showing correctly, without the erros

IMG_1042

mallenexpensify avatar Jan 25 '24 19:01 mallenexpensify

Experiencing the same bug on iOS when I try to upload a photo. The photo at text both post though. (for some reason I thought it might be platform specific) IMG_1045

mallenexpensify avatar Jan 25 '24 19:01 mallenexpensify

@mallenexpensify I can repro! But I am going to assign this back to you since I start mat leave next week and won't be able to see this one through!

NicMendonca avatar Jan 26 '24 21:01 NicMendonca

I'm unavailable next week, Please assign a new C+ Issue here if required while I am away, thanks!

cc: @mallenexpensify

Santhosh-Sellavel avatar Jan 27 '24 16:01 Santhosh-Sellavel

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

melvin-bot[bot] avatar Jan 30 '24 00:01 melvin-bot[bot]

Upwork job price has been updated to $1000

melvin-bot[bot] avatar Jan 30 '24 00:01 melvin-bot[bot]

Raised to $1k to try to get more 👀 on this. Reassigned C+ @Santhosh-Sellavel since I'm hoping we can get this fixed soon. @situchan any thoughts on what might be going on?

mallenexpensify avatar Jan 30 '24 00:01 mallenexpensify

Can I get room invited to reproduce? Seems like not reproducible on normal report

situchan avatar Jan 30 '24 05:01 situchan

@situchan do you have access to the 'high traffic' workspace? If so, are there any rooms in there? I'm checking with QA too

mallenexpensify avatar Jan 30 '24 22:01 mallenexpensify

@mallenexpensify I don't have access. Can I get invited?

situchan avatar Jan 31 '24 03:01 situchan

I invited you @situchan , using your email that's associated with your Slack instance. DM me if that's not the best one. Can you confirm here once you've been granted access? I'm unsure of the process after requesting access

mallenexpensify avatar Feb 02 '24 01:02 mallenexpensify

@mallenexpensify, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Feb 05 '24 15:02 melvin-bot[bot]

@mallenexpensify @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Feb 06 '24 15:02 melvin-bot[bot]

I got access. Which room should I test on? works well on Crowded Policy room

situchan avatar Feb 06 '24 15:02 situchan

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Feb 06 '24 16:02 melvin-bot[bot]

@situchan can you invite me to a room in Crowded Policy and comment here once you have done so? Plz use [email protected] Thanks

mallenexpensify avatar Feb 06 '24 23:02 mallenexpensify

@mallenexpensify as an invitee, I don't have permission to invite someone

Screenshot 2024-02-07 at 9 25 43 AM

And this is workspace chat, not room

situchan avatar Feb 07 '24 03:02 situchan

I created a room on that policy and invited you https://staging.new.expensify.com/r/1369282750079587 image

Know of any easy way to auto-populate that room with a bunch of chats/files. or.. a way to regularly populate it, ie. have a few test accounts post 10 messages in there a day?

mallenexpensify avatar Feb 07 '24 16:02 mallenexpensify

@mallenexpensify @situchan this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

melvin-bot[bot] avatar Feb 13 '24 15:02 melvin-bot[bot]

@mallenexpensify, @situchan Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Feb 13 '24 15:02 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Feb 13 '24 16:02 melvin-bot[bot]

No idea how to proceed since contributors (including me) are not able to reproduce

situchan avatar Feb 13 '24 16:02 situchan

Added Needs Reproduction and bumping to weekly since I'm also unsure of currently reproduction status.

mallenexpensify avatar Feb 13 '24 23:02 mallenexpensify