App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD for payment 2024-02-05] [$250] [TS migration] Migrate 'StatePicker' component to TypeScript

Open melvin-bot[bot] opened this issue 2 years ago • 20 comments

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/StatePicker/index.js 9
src/components/StatePicker/StateSelectorModal.js 12
Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014a79bd886809a56f
  • Upwork Job ID: 1750472348314681344
  • Last Price Increase: 2024-01-25

melvin-bot[bot] avatar Aug 16 '23 22:08 melvin-bot[bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Sep 11 '23 07:09 melvin-bot[bot]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash avatar Nov 13 '23 16:11 VickyStash

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

melvin-bot[bot] avatar Nov 23 '23 13:11 melvin-bot[bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Jan 02 '24 16:01 melvin-bot[bot]

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

melvin-bot[bot] avatar Jan 25 '24 10:01 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~014a79bd886809a56f

melvin-bot[bot] avatar Jan 25 '24 10:01 melvin-bot[bot]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Jan 25 '24 10:01 melvin-bot[bot]

Dibs

ghost avatar Jan 25 '24 10:01 ghost

I'd like to work on this issue

s-alves10 avatar Jan 25 '24 10:01 s-alves10

Upwork job price has been updated to $250

melvin-bot[bot] avatar Jan 25 '24 10:01 melvin-bot[bot]

I can work on this issue

allgandalf avatar Jan 25 '24 10:01 allgandalf

This is done webhook bots 🤖

mountiny avatar Jan 25 '24 11:01 mountiny

lol, jumping here from slack messages 😂 Unaware of the fact that PR was raised already So sorry :)

allgandalf avatar Jan 25 '24 11:01 allgandalf

no problem :D

mountiny avatar Jan 25 '24 11:01 mountiny

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Jan 29 '24 19:01 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.32-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/33352

If no regressions arise, payment will be issued on 2024-02-05. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @VickyStash does not require payment (Contractor)
  • @jjcoffee requires payment (Needs manual offer from BZ)

melvin-bot[bot] avatar Jan 29 '24 19:01 melvin-bot[bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [ ] [@jjcoffee] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [ ] [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot[bot] avatar Jan 29 '24 19:01 melvin-bot[bot]

Not a new feature so I don't think a regression test is needed here!

jjcoffee avatar Feb 05 '24 12:02 jjcoffee

Payment Summary

Upwork Job

  • Contributor: @VickyStash is from an agency-contributor and not due payment
  • ROLE: @jjcoffee paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@mallenexpensify)

  • [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1750472348314681344/hired)
  • [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • [ ] I have verified the payment summary above is correct

melvin-bot[bot] avatar Feb 05 '24 15:02 melvin-bot[bot]

@jjcoffee can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~014a79bd886809a56f

mallenexpensify avatar Feb 06 '24 23:02 mallenexpensify

@mallenexpensify Accepted, thanks for sorting it out!

jjcoffee avatar Feb 07 '24 10:02 jjcoffee

Contributor+: @jjcoffee paid $250 via Upwork

mallenexpensify avatar Feb 07 '24 17:02 mallenexpensify