Expensify
[HOLD for payment 2024-01-28] [TS migration] Migrate 'Task.js' lib to TypeScript
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
| Path | Dependencies |
|---|---|
| src/libs/actions/Task.js | 15 |
Issue Owner
Current Issue Owner: @peterdbarkerUK![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
Triggered auto assignment to @peterdbarkerUK (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.28-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/33111
If no regressions arise, payment will be issued on 2024-01-28. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @akinwale requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@akinwale] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [x] [@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
This caused regression - https://github.com/Expensify/App/issues/35100. Still within regression period cc: @kubabutkiewicz @akinwale
I believe the regression has been minor and hard to catch from such large migration so I propose to keep this $250 for @akinwale
@peterdbarkerUK ready to be paid
Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.
I can help @akinwale!
Payouts due:
Contributor+: $250 @akinwale (paid in Upwork here - https://www.upwork.com/nx/wm/offer/100708240)
Eligible for 50% #urgency bonus? N
Upwork job is here.
Do we need a regression test for this?
Regression Test Steps
- Launch the Expensify app
- Click on the global create menu
- Assign a task
- Add a title and description
- Add a place where you want to share
- Save the task
- Verify that the task was saved with the specified information
- Edit some fields on the task
- Verify that the edited fields are successfully saved
- Mark it as complete
- Verify that it is marked complete
- Mark it as incomplete
- Verify that it is marked as incomplete
- Delete the task
- Verify that the deleted task is not bold in the LHN
Do we agree 👍 or 👎?
cc @Christinadobrzyn
Thanks! @akinwale! I'll pass this along! Thinking about this again, I can't remember if we do regression tests for TS Migration GHs so I'll submit it and ask QA for their thoughts.