[$500] Selection List Refactor: Simple Selection List

[thiagobrez]

This issue keeps track of Phase 3 of the Selection List Refactor, in which we are refactoring all different list component variations into 3 new, clean components:

• Phase 1: Radio Button List
• Phase 2: Checkbox List
• Phase 3: Simple Selection List (this phase)

Thoroughly discussed in the parent issue: https://github.com/Expensify/App/issues/11795#issuecomment-1573880715

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a737edd58e0c740d
• Upwork Job ID: 1698702807486967808
• Last Price Increase: 2023-09-04

Issue Owner

Current Issue Owner: @cristipaval

[thiagobrez]

I imagine I will be able to start on this next week.

[cristipaval]

I forgot to assign you to the issue, @thiagobrez . Sorry for that

[cristipaval]

I'll set this one on hold until the second phase is done.

[thiagobrez]

Starting to investigate this today, while second phase PR is in review

[thiagobrez]

Good news, these lists are fitting well with the new components. Group members list is ready

[thiagobrez]

Update: New Chat list is ready. Will be OOO for the rest of the week, so I'll come back to this on Monday

[thiagobrez]

Hi @shawnborton!

Context:

This issue is Phase 3 of the lists refactor (simple lists, no selection). One of these lists is the New Chat list (image below) ⬇️

Question:

This list is being reused for both New Chat and New Group lists. So I was wondering if maybe you have an update if I can proceed with the New Group list? Last time it was blocked (here) because you still needed to investigate the patterns around checkbox lists.

If there is not a decision on the New Group list yet, no problem, I can make it just for the New Chat list. I'm just checking because if I could change both at the same time, it would make it simpler :)

Thanks!

[shawnborton]

No progress there yet, so let's keep the New Group how it is for now.

[thiagobrez]

Perfect, thanks for the quick response!

[thiagobrez]

Update: Phase 3 is almost finished, will probably already raise the PR once Phase 2 is merged.

All previously investigated lists by Arek https://github.com/Expensify/App/issues/11795#issuecomment-1543877225 were already replaced (with one exception: SearchPage), but I see some lists were missed from the initial investigation (regarding all phases), so I will be adding those here as well.

1. SearchPage is currently being migrated to functional component, so I'm waiting this PR to be merged first before replacing the list

2. Lists in these pages were missed from the initial investigation, so I will be replacing them in this Phase:

• NotificationsPreferencePage
• WriteCapabilityPage
• TaskAssigneeSelectorModal
• TaskShareDestinationSelectorModal
• MoneyRequestConfirmationList
• IOUCurrencySelection
• MoneyRequestParticipantsSplitSelector

[thiagobrez]

Update: Phase 3 is almost finished, will probably already raise the PR once Phase 2 is merged.

[thiagobrez]

Update: Phase 3 is almost finished, will probably already raise the PR once Phase 2 is merged.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[cristipaval]

We'll start on this soon I guess, Melv

[thiagobrez]

@cristipaval Actually, Phase 3 was already in the works while Phase 2 was being reviewed, it's in a local branch. Next week I'll split it in smaller PRs as agreed in the thread

[cristipaval]

Great! Thank you @thiagobrez!

[cristipaval]

This is in progress, Melv!

[thiagobrez]

Hey @cristipaval, can I send multiple PRs to this same issue and link here, or we also need to create a new issue for each PR?

[cristipaval]

no need to create new issues for each. Just make sure you add the PR scope in the description body.

[cristipaval]

I think this issue is not on hold anymore, is it?

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01a737edd58e0c740d

[melvin-bot[bot]]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[cristipaval]

Added External label to have bug zero and a c+ assigned.

[rushatgabhane]

Alright, I think we're just waiting for a PR from @thiagobrez, right?

[thiagobrez]

Hey @rushatgabhane , yeah I will be sending a few PRs here. Just FYI that most of Callstack is off this week due to RNEU. I'll get back to this on Monday!

[melvin-bot[bot]]

@JmillsExpensify, @cristipaval, @thiagobrez, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

@JmillsExpensify, @cristipaval, @thiagobrez, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

[thiagobrez]

Update: We're progressing here. I'll send a few small focused PRs here to review more easily. First one is regarding this issue, in which I posted a question before I can proceed

[thiagobrez]

Holding on New Chat and New Group list replacements due to the new Global create feature that will come soon, as discussed here: https://github.com/Expensify/App/issues/12668#issuecomment-1714039010