Fix for: Web - Triple clicking an edited message select’s the (edited) label along with the actual message

[Ollyws]

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/15194 PROPOSAL: https://github.com/Expensify/App/issues/15194#issuecomment-1446483267

Tests

1. Navigate to any conversation
2. Send an message -> Edit that message (make sure it has the (edited) label at end)
3. Select the message by triple clicking on the message itself
4. Verify that the message, and not the (edited) label are selected

• [x] Verify that no errors appear in the JS console

Offline tests

1. Navigate to any conversation
2. Send an message -> Edit that message (make sure it has the (edited) label at end)
3. Select the message by triple clicking on the message itself
4. Verify that the message, and not the (edited) label are selected

QA Steps

1. Navigate to any conversation
2. Send an message -> Edit that message (make sure it has the (edited) label at end)
3. Select the message by triple clicking on the message itself
4. Verify that the message, and not the (edited) label are selected

• [ ] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android / native
  • [x] Android / Chrome
  • [x] iOS / native
  • [x] iOS / Safari
  • [x] MacOS / Chrome / Safari
  • [x] MacOS / Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If a new component is created I verified that:
  • [x] A similar component doesn't exist in the codebase
  • [x] All props are defined accurately and each prop has a /** comment above it */
  • [x] The file is named correctly
  • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [x] The only data being stored in the state is data necessary for rendering and nothing else
  • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [x] All JSX used for rendering exists in the render method
  • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/11609254/233348316-96852de8-494d-485c-99ed-01a49ea3220e.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/11609254/233348357-44d25f5d-7c70-442f-a1ec-c191f3ef0a96.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/11609254/233348384-52419776-a192-4f6f-a192-b9b864b6b081.mp4

Desktop

https://user-images.githubusercontent.com/11609254/233348419-b77e1be7-1b88-4028-b12a-de0c16c99799.mp4

iOS

https://user-images.githubusercontent.com/11609254/233773755-8b9840a1-8568-4554-bdc9-2da105cca322.mp4

Android

https://user-images.githubusercontent.com/11609254/233348475-61e2a1cc-558b-4baf-b816-a3acb8362413.mp4

[MelvinBot]

@marcochavezf @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Ollyws]

@parasharrajat @marcochavezf I have applied the changes I outlined here, to ensure it works correctly on firefox and also fixes this issue.

The horizontal alignment of the label (when not using EditedRenderer) is slightly different than on production. It can be easily fixed by changing the width style of the space (currently 4px), to 3px. However I thought I would check with you guys as it seems like it was unintentional to have the labels from EditedRenderer and ReportActionItemFragment with a different alignment, and mirroring this mis-alignment for the sake of consistency with production seemed potentially undesirable.

Also there is the issue where when selecting and copying the (edited) label with triple click causes the issues seen in https://github.com/Expensify/App/issues/15810 to persist, however (although potentially out of scope for this issue) I outlined a potential simple fix for this here and fix for the reaction emojis being copied here.

[marcochavezf]

However I thought I would check with you guys as it seems like it was unintentional to have the labels from EditedRenderer and ReportActionItemFragment with a different alignment, and mirroring this mis-alignment for the sake of consistency with production seemed potentially undesirable.

Hi @Ollyws, could you take screenshots of how these elements are misaligned? Those elements were probably implemented separately before; if that's the case, I agree we should fix them.

[marcochavezf]

Also there is the issue where when selecting and copying the (edited) label with triple click causes the issues seen in https://github.com/Expensify/App/issues/15810 to persist, however (although potentially out of scope for this issue) I outlined a potential simple fix for this https://github.com/Expensify/App/issues/15194#issuecomment-1514377262 and fix for the reaction emojis being copied https://github.com/Expensify/App/issues/15194#issuecomment-1514562267.

Could you include those fixes in this PR too?

[parasharrajat]

Yes, can you share the screenshots to clarify.

[Ollyws]

Hi @Ollyws, could you take screenshots of how these elements are misaligned? Those elements were probably implemented separately before; if that's the case, I agree we should fix them.

@marcochavezf Here's the difference between EditedRenderer and ReportActionItemFragment on production. It's only a 1px difference so hardly noticable. But they both have even values in this PR.

[Ollyws]

@parasharrajat @marcochavezf These two commits should fix https://github.com/Expensify/App/issues/15810 which in our case is triple click selection which selects the (edited) label and also copies the reaction emojis. Removing userSelectNone will ofcourse allow the user to select the reaction emojis by dragging, I hope this is acceptable.

[marcochavezf]

@marcochavezf Here's the difference between EditedRenderer and ReportActionItemFragment on production. It's only a 1px difference so hardly noticable. But they both have even values in this PR.

Oh that's fine, the difference is pretty minor

[marcochavezf]

Hi @Ollyws could you resolve the conflict with ReportActionItem?

[Ollyws]

@marcochavezf All done.

[marcochavezf]

Thanks @Ollyws, @parasharrajat let's review this one asap to keep our WAQ goal 🚀

[parasharrajat]

I will do that as soon. Currently working on an internal PR which is urgent.

[Ollyws]

@marcochavezf @parasharrajat I made these changes to stop it throwing an error on iOS, note we already do the same thing with many other styles. Hope this is OK.

[Ollyws]

@parasharrajat Any thoughts?

[parasharrajat]

Gonna check this today before EOD.

[Ollyws]

Gonna check this today before EOD.

@parasharrajat Any progress.....?

[parasharrajat]

I am away for 3:30 hrs. Then I will start the review process here.

[parasharrajat]

I am curious about the end result after https://github.com/Expensify/App/pull/17496 is merged. let's just wait for some time and I am sure that it will be merged today.

[Ollyws]

@parasharrajat Updated.

[Ollyws]

@parasharrajat @marcochavezf Reverted these two commits because the emoji copying issue will be solved by https://github.com/Expensify/App/pull/18228

[parasharrajat]

@Ollyws I would say that you put back the MiniReportActionContextMenu change as it does not affect anything but solves a bug. It is good if #18228 make is future-proof.

let me know if you disagree.

[parasharrajat]

Screenshots

:black_square_button: iOS / native

https://user-images.githubusercontent.com/24370807/235654822-8de4a9c4-6333-4cce-b5ba-9dd3c3a804fc.mov

:black_square_button: iOS / Safari

https://user-images.githubusercontent.com/24370807/235654636-92edc028-a6e8-4457-b784-ab2bb6c60bf0.mov

:black_square_button: MacOS / Desktop

https://user-images.githubusercontent.com/24370807/235657611-def0af4a-add6-4a3a-ac68-f28dbbb7d55d.mov

:black_square_button: MacOS / Chrome

https://user-images.githubusercontent.com/24370807/235654845-e8f73efe-6693-4079-9f51-3d702f60f08e.mov

:black_square_button: Android / Chrome

https://user-images.githubusercontent.com/24370807/235656054-a0adcd41-52d3-433f-924f-1974d68705c5.mov

:black_square_button: Android / native

[Ollyws]

@parasharrajat Ok, moved it back.

[Ollyws]

@parasharrajat Updated.

[parasharrajat]

There are a couple of questions above @marcochavezf in the review comments. Apart from these, I think it is working well. There are cases where triple click still selects extra elements but that is outside the scope of this PR and there are already PR that are trying to solve that.

[marcochavezf]

Yeah, I agree the selection of extra elements is not part of the scope of the PR. Also, I don't think there's a problem with the current platform file usage in the PR. Eventually, if we identify an issue, we should solve all the instances of platform file usage.

[OSBotify]

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.9-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[Ollyws]

@marcochavezf @parasharrajat Unsure about the procedure here as it's the first time I've had a PR reverted. We decided to keep the change of MiniReportActionContextMenu just for good measure, although it's not necessary. We can remove it without any problems which will solve the issue that caused the deploy blocker.

[OSBotify]

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅