Bug: DEV - [iOS] dev console error on app launch reported by @aimane-chnaif

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app

Expected Result:

No console error

Actual Result:

Console error: Warning: RCTBridge required dispatch_sync to load REAModule. This may lead to deadlocks

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: v1.2.19-2 Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Expensify/Expensify Issue URL: Issue reported by: @aimane-chnaif Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666759616071549

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @MitchExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[dhairyasenjaliya]

Proposal

• This warning is caused by the react-native-reanimated package below is the PR that recently they fixed in the package PR: https://github.com/software-mansion/react-native-reanimated/pull/3698/files

• But we are currently using 3.0.0-rc.3 so I think we need to add the below changes to the patch here https://github.com/Expensify/App/tree/main/patches

file : REAModule.mm


#ifdef RCT_NEW_ARCH_ENABLED
+ (BOOL)requiresMainQueueSetup
{
  return YES;
}
#endif // RCT_NEW_ARCH_ENABLED

Result fix

Issue

[MitchExpensify]

How do you pull up the console warning screen? Trying to reproduce

[melvin-bot[bot]]

@MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Hey @kavimuru, mind helping me with this question?: How do you pull up the console warning screen?

Thanks!

[kavimuru]

@MitchExpensify I can't check Dev only issue. So I added Needs reproduction label. @aimane-chnaif can clarify your question.

[aimane-chnaif]

@MitchExpensify were you not able to see this warning on iOS simulator?

https://user-images.githubusercontent.com/47522946/198195342-d6e6faca-0100-4cd7-b1e2-d63d39c17afe.png

[MitchExpensify]

@aimane-chnaif How exactly do I pull up the console warning screen?

[aimane-chnaif]

https://user-images.githubusercontent.com/96077027/199385170-b32d5a95-5b77-4740-8c5d-b6790c04c54c.mp4

cc: @MitchExpensify

[MitchExpensify]

Sorry, I'm asking how you pull up that console warning as I am not sure when trying to reproduce @aimane-chnaif

[michaelhaxhiu]

Hey @MitchExpensify, just dropping a note as a reminder to keep the pressure on finding a contributor and get this one closed out.

PS whatever you learn from this about the "console" question let's post in Stack Overflow for the future. I don't remember the answer myself (and I'm sure I asked before too 😨)

[michaelhaxhiu]

Just bumped the associated slack thread to make sure we have movement!

[melvin-bot[bot]]

@MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

Asked for help reproducing in #contributor-plus

[melvin-bot[bot]]

@MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

Triggered auto assignment to @zanyrenney (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot[bot]]

Triggered auto assignment to @Luke9389 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MitchExpensify]

Doubled! - Upwork Job

[aimane-chnaif]

Proposal

This console error came from react-native-reanimated package. Current version is 3.0.0-rc.3 It's fixed in 3.0.0-rc.4 or newer

Solution We can use any newer versions: 3.0.0-rc.4 or 3.0.0-rc.5 or 3.0.0-rc.6 https://github.com/Expensify/App/blob/ef0df807dd60c5cddea86e704a70ba7e27f98b5c/package.json#L106 And update package-lock.json accordingly

[hannojg]

Agree, plus remove the patch file i added manually!

[eVoloshchak]

@dhairyasenjaliya's proposal beat everyone else by 3 weeks, they were the first to correctly identify the root cause. We should just update to 3.0.0-rc.4 or newer

🎀👀🎀 C+ reviewed! cc: @Luke9389

[dhairyasenjaliya]

IMO we should just update to 3.0.0-rc.4 since we have the RN version of [email protected] whereby 3.0.0-rc.5 added RN version of 0.75 although it shouldn't be a problem even if we added rc.5 or rc.6 but worth mentioning :)

also while testing I found these 2 warnings on main branch without updating reanimated on web should I log in to slack?

1. react_devtools_backend.js:4026 Animated: useNativeDriver is not supported because the native animated module is missing.

2. The native module for Flipper seems unavailable. Please verify that `react-native-flipper

cc PR ready for initial review @eVoloshchak

[hannojg]

IMO we should just update to 3.0.0-rc.4 since we have the RN version of [email protected] whereby 3.0.0-rc.5 added RN version of 0.75

Kindly disagreeing. This is only with regards to the example app within the react-native-reanimated, so it can be "ignored" 😊

[dhairyasenjaliya]

Kindly disagreeing. This is only with regards to the example app within the react-native-reanimated, so it can be "ignored" 😊

alright, so we can directly use the latest version then :)

[michaelhaxhiu]

Awaiting approval from @Luke9389 in order to hire @dhairyasenjaliya and kick off the PR process.

[puneetlath]

@Luke9389 To help us clear out the large backlog of /App bugs, we're putting the spotlight every bug in the repo already than 4 weeks old. To help unblock the roadmap and get our bug pipeline back in equilibrium, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is
• For any that can't, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #bug-zero

[dhairyasenjaliya]

bump awaiting for @Luke9389 to pass 🟢 for initial review :)

[eVoloshchak]

Not overdue, waiting for the proposal review