Expensify
Android - Concierge- Composed box looks expended and cursor is overlapping the text when placeholder content is long
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- Launch the app
- Log in with expensifail account
- Search for Concierge
- Check composed box and tap on it
Expected Result:
Composed box should be normal and cursor should not overlap with text
Actual Result:
Composed box looks expended and cursor is overlapping the text
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Android
Version Number: 1.2.7.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/192596594-a1adc5ed-bac8-4089-bc15-f5a5fe54310b.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
hmmm, I would believe this is related to the screen size being too small? cc @Expensify/design what do you think of this? What should happen in this case if the phone is too narrow?
Triggered auto assignment to @michelle-thompson (Design), see these Stack Overflow questions for more details.
Hmm maybe we just need to make these suggested hints shorter? Is there discussion somewhere from where this was implemented?
Yeah, even without the cursor error it's not ideal to have two lines of suggested text.
@michelle-thompson Whoops! This issue is 2 days overdue. Let's get this updated quick!
@michelle-thompson Whoops! This issue is 2 days overdue. Let's get this updated quick!
I think the easiest thing to do here would just be to shorten the hint text - thoughts?
So we could rephrase the above hint text to the following:
- "Ask how to scan receipts!"
- "Ask for free corporate cards!"
- "Ask how to send invoices!"
@iwiznia what do you think about this?
Triggered auto assignment to @joaniew (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.
@joaniew, @michelle-thompson Eep! 4 days overdue now. Issues have feelings too...
Do we need multiple inputs here? Is there a character limit or number we're aiming for when we say its too long/short?
Maybe a simple "How can I help?"
This is occurring from the concierge placeholder options we have here.
We will need to update both the en.js and es.js files.
It is the last 3 entries that are creating issues. So we can just rephrase those ones?
@shawnborton, @joaniew Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Yes, that makes sense to me! Either replace them or don't show them on smaller screens.
Ask me how to scan a receipt - 28 characters, so we should do less than that. Ask me how to pay people - 24 characters, so that is ok.
I don't think they all have to start with Ask me - seems arbitrary so suggesting the below using those character parameters:
- Help me get reimbursed (22 characters)
- How can I help? (16 characters)
- Questions? I can help! (24 characters)
or agree with shawn to cut the last 3.
@shawnborton, @joaniew Huh... This is 4 days overdue. Who can take care of this?
@shawnborton, @joaniew Huh... This is 4 days overdue. Who can take care of this?
Issue not reproducible during KI retests. (Third week) Are we ok to close this one?
@shawnborton, @joaniew Eep! 4 days overdue now. Issues have feelings too...
I think the best solution will be to ignore the last 3 options on smaller screens. I am going to push a PR today to update it.