App icon indicating copy to clipboard operation
App copied to clipboard

rtf file is corrupted in the preview. The inside text changes - Reported by @Tushu17

Open mvtglobally opened this issue 3 years ago • 10 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open website.
  2. Go to Chat > Send a .rtf attachment.
  3. Preview the attachment

Expected Result:

It shouldn't get corrupted.

Actual Result:

It gets corrupted.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.88-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/184222042-ecc8db3d-7724-4c5e-8180-8b638398e3da.mov

Expensify/Expensify Issue URL: Issue reported by: @Tushu17 Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1658854329649929

View all open jobs on GitHub

mvtglobally avatar Aug 11 '22 19:08 mvtglobally

Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

melvin-bot[bot] avatar Aug 11 '22 19:08 melvin-bot[bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] avatar Aug 11 '22 19:08 melvin-bot[bot]

It seems like the file gets corrupted after being processed by our server. Downloading the file and trying to open it results in an error as well, so it's not only the preview. I add the internal label and release this back to the pool!

luacmartins avatar Aug 12 '22 15:08 luacmartins

A Contributor Manager will be assigned to issue payment via Upwork if we deploy an associated Pull Request to production. Per Contributing.md.

melvin-bot[bot] avatar Aug 12 '22 15:08 melvin-bot[bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Sep 05 '22 07:09 melvin-bot[bot]

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

melvin-bot[bot] avatar Oct 18 '22 18:10 melvin-bot[bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

melvin-bot[bot] avatar Oct 18 '22 19:10 melvin-bot[bot]

We seem to create thumbnails for text files too and it ends up corrupting the .rtf file, I think we should limit creating thumbnails to PDFs and images only. I will keep this assigned to me as I'm working on file uploads. I will also post in slack for some input about what filetypes we want to create thumbnails for.

youssef-lr avatar Oct 19 '22 16:10 youssef-lr

@youssef-lr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Oct 31 '22 07:10 melvin-bot[bot]

@youssef-lr Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Oct 31 '22 08:10 melvin-bot[bot]

@youssef-lr Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Nov 02 '22 08:11 melvin-bot[bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Nov 02 '22 17:11 melvin-bot[bot]

@youssef-lr I removed and re-added the bug label to get a BZ team member added who can help move this forward.

puneetlath avatar Nov 02 '22 17:11 puneetlath

Though actually, it looks like a PR was already merged. Is this done? And if so, can we close it?

puneetlath avatar Nov 02 '22 17:11 puneetlath

Yeah this has been fixed, I just tested again in production. Closing!

youssef-lr avatar Nov 02 '22 17:11 youssef-lr

Reporting compensation is pending here. cc- @puneetlath @sakluger

Tushu17 avatar Nov 03 '22 09:11 Tushu17

Whoops. Reopening. @sakluger let's make sure @Tushu17 get's paid the reporting bonus.

puneetlath avatar Nov 03 '22 14:11 puneetlath

@sakluger Bump.

Tushu17 avatar Nov 09 '22 15:11 Tushu17

@sakluger, @youssef-lr Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Nov 10 '22 08:11 melvin-bot[bot]

Looks like @sakluger is out sick.

@Tushu17 can you apply here? https://www.upwork.com/jobs/~01c9813ff18e057735

puneetlath avatar Nov 10 '22 13:11 puneetlath

@puneetlath Okay applied, Thanks.

Tushu17 avatar Nov 10 '22 14:11 Tushu17

Paid! Thanks for your patience and thanks for the bug report.

puneetlath avatar Nov 10 '22 18:11 puneetlath