stream-registry icon indicating copy to clipboard operation
stream-registry copied to clipboard
verified publisher icon ExpediaGroup

Investigate possible dead code involving topicConfig

Open neoword opened this issue 6 years ago • 1 comments

Desired Behavior

See this possible dead code involving topicConfig.

https://github.com/homeaway/stream-registry/blob/553345fff8ed6997c1134820343ca6677ee4596b/core/src/main/java/com/homeaway/streamplatform/streamregistry/db/dao/AbstractDao.java#L160-L163

Seems like this code can be deleted and have no effect at all. If true, topicConfigMap argument is totally ignored.

Benefits

  • topicConfigMap won't be ignored and will be stored on various streams

Recommendation

  • If indeed ignored... remove from method signature and add new issue to support topicConfig at appropriate level (probably when bindings #31 are supported)

neoword avatar Mar 02 '19 00:03 neoword

cc: @prabhakar1983 can you investigate and provide a PR ?

neoword avatar Mar 02 '19 00:03 neoword