stream-registry icon indicating copy to clipboard operation
stream-registry copied to clipboard

Consider adding forceSync=true for topic updates

Open neoword opened this issue 7 years ago • 2 comments

Desired Behavior

Add forceSync=true for updating of topic metadata.

[UPDATED]

This issue is a direct result of #52, in an attempt to resolve the "dead-end" a user will inevitably run into when they get an error from #52.

Benefits

  • See https://github.com/homeaway/stream-registry/blob/bacfe0a5d61fa4102bd0ff521f80d60ff90257e2/core/src/main/java/com/homeaway/streamplatform/streamregistry/db/dao/impl/KafkaManagerImpl.java#L128-L134
  • Default should be forceSync=false resulting in error (current behavior)
  • When users get this error, by adding forceSync=true , stream-registry can get the value from the underlying broker and "force" update itself to be in sync with the underlying broker.

neoword avatar Feb 09 '19 02:02 neoword

RE: "topic: " + topic " already exists but config is different than requested!"

Should the property instead be named something along the lines of

  • useExistingTopicConfig
  • allowConfigIfExists
  • allowConfigMismatch

OneCricketeer avatar Apr 26 '19 22:04 OneCricketeer

Actually I am thinking this enhancement should sync the SR with the underlying broker metadata? @cricket007 do you agree?

neoword avatar May 07 '19 16:05 neoword