change print of Exif.Canon.SerialNumber

[norbertwg]

reference: #2792 In general serial number is just printed as decimal. Exception for EOS D30, where higher bytes are printed as hex, lower bytes as decimal, the format, which was used for all Canon devices before this change. Output is now aligned with Canon Photo Digital Professional 4 (except leading zeros). A few exceptions, where the images have two entries in Exif.Canon.SerialNumber (which looks strange): then Canon Photo Digital Professional shows only one number. As print0x000c was also used for 0x000a, new function print0x000a as copy from old print0x000c.

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.89%. Comparing base (f551534) to head (ef27287). Report is 97 commits behind head on main.

:exclamation: Current head ef27287 differs from pull request most recent head 051d00b. Consider uploading reports for the commit 051d00b to get more accurate results

Files	Patch %	Lines
src/canonmn_int.cpp	91.66%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2806      +/-   ##
==========================================
+ Coverage   63.88%   63.89%   +0.01%     
==========================================
  Files         103      103              
  Lines       22381    22392      +11     
  Branches    10873    10881       +8     
==========================================
+ Hits        14297    14307      +10     
  Misses       5862     5862              
- Partials     2222     2223       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[neheb]

rebase to main

[norbertwg]

I did a rebase.

[norbertwg]

This pull request is waiting for approving review since 5 months. Are there reasons not to approve this request or was it just lost out of sight?

[kmilos]

Please fix the CodeQL warnings: either check the exifData before dereference, or wrap in a try/catch block.

[norbertwg]

CodeQL warnings are fixed, but "On PRs - Mac Special Builds / macOS - XCode - Release+Sanitizers (pull_request)" fails. From job output I have no idea, what is the reason for that.

[kmilos]

Thanks. That one has been failing for a while, and is not related to your change. I'll take another pass and approve when O get a chance.

[kmilos]

@mergify backport 0.28.x

[mergify[bot]]

backport 0.28.x

✅ Backports have been created

• #2971 change print of Exif.Canon.SerialNumber (backport #2806) has been created for branch 0.28.x